Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#34031 closed enhancement (fixed)

oEmbed: Add VideoPress as a provider

Reported by: kraftbj's profile kraftbj Owned by: johnbillion's profile johnbillion
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch
Focuses: Cc:

Description

VideoPress now has permalinks with oEmbed support, based on the WP.com oEmbed API (already supported). We already support WordPress.tv, which is, at this point, a "wrapped" for VideoPress.

Per the core list:

  • Is the service is popular enough for core developers to have heard of it before? Is it “mainstream?”

As WP-centric video hosting, I think it is popular without our ecosystem.

  • If similar services are already supported, how does this service compare in terms of size, features, and backing?

The revamp brought it on par with player features in FB, Vimeo. Since VideoPress is focused as WordPress video hosting, there is not a separate "portal".

  • Does this service have a large following on Twitter, Facebook, or other social media? Is its Twitter account verified?

As part of the offering from WordPress.com, I'd say that WP.com's following is sufficient.

  • Is its oEmbed endpoint clearly established and properly documented? (Sometimes, they are just a developer’s pet project that may not be supported.)

It is part of the WP.com API. Details, including VideoPress reference: https://developer.wordpress.com/docs/oembed-provider-api/

  • Does the service make an effort to build relationships with developers, such as through robust APIs?

While being an Automattic property merits zero special consideration, being so close to Core dev, all ears!

  • How old is the service?

First iteration: 2009.
Revamp that added oEmbed/permalinks: July 2015

  • Does it have a well-established Wikipedia article? (Seriously.)

No. It is mentioned under https://en.wikipedia.org/wiki/Automattic, but does not have anything more as far as I know.

  • Has anyone written a WordPress plugin that leverages the service in some way, whether adding it as an oEmbed provider, creating a shortcode, or leveraging other APIs of the service? Do these plugins have any noticeable adoption or traction that would indicate usage and demand?

Jetpack has a VideoPress module that enables many features natively for self-hosted sites, which is slated for near-future improvements. It creates a shortcode and adds VideoPress as an oEmbed provider.

  • Is the provider frequently proposed?

Unknown.

Additionally, I'll note that the lack of a native VideoPress oEmbed on Core caused some confusion for the 4.3 release video (first since the enhancement). While WordPress.tv URLs work in Core, folks attempting to paste in the share URL from the player (videopress) found it unsuccessful.

Attachments (2)

34031.diff (1.5 KB) - added by kraftbj 10 years ago.
Adds VP as a provider.
34031.2.diff (1.5 KB) - added by kraftbj 10 years ago.
urlencode is better :) Thanks John!

Download all attachments as: .zip

Change History (9)

@kraftbj
10 years ago

Adds VP as a provider.

#1 @kraftbj
10 years ago

  • Keywords has-patch added

Some notes about the patch:

  1. Spacing needs to be adjusted if/when committed. Opted for the minimal functional change for the patch for the sake of conversation. Can update upon request :)
  1. The WP.com oEmbed API requires a for parameter for the requesting site. I've opted to set this as a variable before the array for future use, if others in the future need something like this.
  1. I've opted to add the query string directly onto the URL as it is done for other providers higher up in the array.

#2 follow-ups: @johnbillion
10 years ago

  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Review to 4.4

Thanks for the patch. Moving to the next major release milestone for consideration as we always do.

VideoPress crossed my mind once before, but upon looking into it it appears that VideoPress only works with either a) WordPress.com, or b) Jetpack. So, what's the use case for supporting VideoPress in core?

Also the for query variable probably needs to be urlencode()-d rather than escaped.

#3 in reply to: ↑ 2 @johnbillion
10 years ago

  • Keywords reporter-feedback removed

Replying to johnbillion:

So, what's the use case for supporting VideoPress in core?

Answering my own question, I hadn't realised that VideoPress videos had shareable URLs. So that's the use-case.

@kraftbj
10 years ago

urlencode is better :) Thanks John!

#4 in reply to: ↑ 2 @kraftbj
10 years ago

Replying to johnbillion:

Also the for query variable probably needs to be urlencode()-d rather than escaped.

You're right. Updated to urlencode. esc_url is for display, not this.

#5 @azaozz
10 years ago

34031.2.diff looks good. Wondering if we should pass just the domain, but either seems good.

#6 @wonderboymusic
10 years ago

  • Owner set to johnbillion
  • Status changed from new to assigned

#7 @johnbillion
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34785:

Add VideoPress as a trusted oEmbed provider.

Fixes #34031
Props kraftbj

Note: See TracTickets for help on using tickets.