Plugin "Install Now" button is vertically misaligned

[paulwilde]

The "Install Now" button is misaligned vertically on the Plugin Detail modal.

Patch and screenshots attached.

[paulwilde]

Cannot edit the description of my ticket, but I meant 'Plugin Info modal' not "Plugin Info plugin".

[afercia]

Good catch. Thinking maybe we should also tweak the "equal height column trick" for the content and sidebar and make the total height footer (including border) 60px to keep math simple.

[afercia]

Reviewing a bit the dialog modal CSS, there are things I don't fully understand and probably are leftovers, unless I'm missing something. For example the class .wrap should be reserved for the main content wrapper in the admin screens and not user here. Also, don't know what is supposed to do setting an element to position: relative; and then specifying the position properties set to 0, e.g.:

position: relative;
top: 0;
right: 0;
left: 0;

By the way these are things out of the scope of this ticket and should go in a separate ticket as part of a major CSS cleaning. cc @helen :)

[afercia]

Screenshot with latest patch applied:

[afercia]

In 35343:

Plugins: Improve the "Install Now" button vertical alignment in the Plugin Details modal dialog.

Props paulwilde.

Fixes #34199.