WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#34199 closed defect (bug) (fixed)

Plugin "Install Now" button is vertically misaligned

Reported by: paulwilde Owned by: afercia
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Plugins Keywords: has-patch has-screenshots commit
Focuses: ui Cc:

Description (last modified by afercia)

The "Install Now" button is misaligned vertically on the Plugin Detail modal.

Patch and screenshots attached.

Attachments (3)

34199-before.png (459.5 KB) - added by paulwilde 6 years ago.
34199-after.png (420.5 KB) - added by paulwilde 6 years ago.
34199.diff (421 bytes) - added by paulwilde 6 years ago.

Download all attachments as: .zip

Change History (9)

@paulwilde
6 years ago

@paulwilde
6 years ago

#1 @paulwilde
6 years ago

  • Keywords has-patch added

Cannot edit the description of my ticket, but I meant 'Plugin Info modal' not "Plugin Info plugin".

Last edited 6 years ago by paulwilde (previous) (diff)

#2 @afercia
5 years ago

  • Description modified (diff)

Good catch. Thinking maybe we should also tweak the "equal height column trick" for the content and sidebar and make the total height footer (including border) 60px to keep math simple.

#3 @afercia
5 years ago

Reviewing a bit the dialog modal CSS, there are things I don't fully understand and probably are leftovers, unless I'm missing something. For example the class .wrap should be reserved for the main content wrapper in the admin screens and not user here. Also, don't know what is supposed to do setting an element to position: relative; and then specifying the position properties set to 0, e.g.:

position: relative;
top: 0;
right: 0;
left: 0;

By the way these are things out of the scope of this ticket and should go in a separate ticket as part of a major CSS cleaning. cc @helen :)

#4 @afercia
5 years ago

  • Keywords has-screenshots commit added

Screenshot with latest patch applied:

https://cldup.com/HkwyJb5UtG.png

#5 @afercia
5 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to afercia
  • Status changed from new to assigned
  • Version changed from trunk to 4.3

#6 @afercia
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35343:

Plugins: Improve the "Install Now" button vertical alignment in the Plugin Details modal dialog.

Props paulwilde.

Fixes #34199.

Note: See TracTickets for help on using tickets.