Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#34425 closed defect (bug) (fixed)

Add global variable description in WP_Comments_List_Table::handle_row_actions

Reported by: shimakyohsuke's profile shimakyohsuke Owned by: drewapicture's profile DrewAPicture
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Comments Keywords: has-patch
Focuses: docs Cc:

Description (last modified by swissspidy)

add global variable description in wp-admin/includes/class-wp-comments-list-table.php

Attachments (1)

class-wp-comments-list-table.php.diff (547 bytes) - added by shimakyohsuke 8 years ago.

Download all attachments as: .zip

Change History (4)

#1 @swissspidy
8 years ago

  • Description modified (diff)
  • Summary changed from add global valiavle description in 'wp-admin/includes/class-wp-comments-list-table.php' to Add global variable description in WP_Comments_List_Table::handle_row_actions

Thanks for the patch!

Just note that globals need a small description according to the inline documentation standards.

That being said, I think the whole class could benefit from improved documentation.

#2 @DrewAPicture
8 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.4
  • Version changed from trunk to 4.3

Hi @shimakyohsuke, thanks for the patch!

#3 @DrewAPicture
8 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 35490:

Docs: Document use of the $comment_status global in the DocBlock for WP_Comments_List_Table::handle_row_actions().

Props shimakyohsuke.
Fixes #34425.

Note: See TracTickets for help on using tickets.