WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#34434 closed defect (bug) (fixed)

Filter to Skip Plugin/Theme/Translation Notifications Partially Ignored

Reported by: ronalfy Owned by: johnbillion
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: Upgrade/Install Keywords: has-patch needs-testing
Focuses: administration Cc:

Description (last modified by johnbillion)

See original committed ticket: #33932

Since the array is already populated, the return condition is never met.

Attachments (3)

patch.diff (1.7 KB) - added by ronalfy 5 years ago.
Patch to address return condition
patch2.diff (1.7 KB) - added by ronalfy 5 years ago.
Fixing variable assigning.
patch3.diff (1.7 KB) - added by ronalfy 5 years ago.
Fix for breakage of automatic updates

Download all attachments as: .zip

Change History (12)

@ronalfy
5 years ago

Patch to address return condition

#1 @kidsguide
5 years ago

  • Keywords has-patch added

@ronalfy
5 years ago

Fixing variable assigning.

#2 @ronalfy
5 years ago

  • Keywords 2nd-opinion needs-testing added

My apologies. My first patch forgot to re-assign merged array values to the $body variable.

@ronalfy
5 years ago

Fix for breakage of automatic updates

#3 @ronalfy
5 years ago

Patch 2 for some reason broke automatic updates. I made a very minor change in Patch 3 and automatic updates were working again. I honestly don't know why Patch 2 broke because I can't really tell the difference between Patch 2 and Patch 3.

Anyways, I tested Patch 3 against WordPress 4.4 Beta 1 and automatic updates are working fine.

I also tested the 4.4 send_update_notification_email filter for plugin/theme automatic updates and it worked as it should (not sending out any emails).

I can test core updates assuming this makes it into 4.4 Beta 2.

#4 @johnbillion
5 years ago

  • Owner set to johnbillion
  • Status changed from new to reviewing

#5 @johnbillion
5 years ago

  • Description modified (diff)
  • Keywords 2nd-opinion removed

#6 @ronalfy
5 years ago

I'm not trying to rush anybody, but I saw that Beta 2 was released. Just want to note that if the patch above isn't committed or isn't planned on 4.4, then #33932 needs to be reverted. It breaks my heart to say this because I've been wanting to commit to core for a while.

#7 @johnbillion
5 years ago

  • Milestone changed from Awaiting Review to 4.4

This ticket was mentioned in Slack in #core by wonderboymusic. View the logs.


5 years ago

#9 @ocean90
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35619:

Upgrade: Revert [34543] because of incomplete and incorrect functionality.

See #33932.
Fixes #34434.

Note: See TracTickets for help on using tickets.