Filter to Skip Plugin/Theme/Translation Notifications Partially Ignored

[ronalfy]

See original committed ticket: #33932

Since the array is already populated, the return condition is never met.

[ronalfy]

Patch to address return condition

[ronalfy]

Fixing variable assigning.

[ronalfy]

My apologies. My first patch forgot to re-assign merged array values to the $body variable.

[ronalfy]

Fix for breakage of automatic updates

[ronalfy]

Patch 2 for some reason broke automatic updates. I made a very minor change in Patch 3 and automatic updates were working again. I honestly don't know why Patch 2 broke because I can't really tell the difference between Patch 2 and Patch 3.

Anyways, I tested Patch 3 against WordPress 4.4 Beta 1 and automatic updates are working fine.

I also tested the 4.4 send_update_notification_email filter for plugin/theme automatic updates and it worked as it should (not sending out any emails).

I can test core updates assuming this makes it into 4.4 Beta 2.

[ronalfy]

I'm not trying to rush anybody, but I saw that Beta 2 was released. Just want to note that if the patch above isn't committed or isn't planned on 4.4, then #33932 needs to be reverted. It breaks my heart to say this because I've been wanting to commit to core for a while.

[ocean90]

In 35619:

Upgrade: Revert [34543] because of incomplete and incorrect functionality.

See #33932.
Fixes #34434.