WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 5 months ago

#34592 new defect (bug)

wptexturize interprets apostrophe at end of word as closing single quote

Reported by: floffimedia Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.3
Component: Formatting Keywords:
Focuses: Cc:
PR Number:

Description

In the example

Let's meet at Chris' place

wptexturize interprets the first special character as an apostrophe and the second special character as a closing curly single quote.

In English, the result is ’ regardless. However, some localization files use closing curly single quotes that differ from apostrophes.

Change History (4)

#1 follow-ups: @miqrogroove
4 years ago

Excuse my disagreement, but formal grammar in English requires a possessive proper noun to be followed by the letter "s", as in, "Let's meet at Chris's place."

Perhaps we can construct a "correct" test case:

"The boys win. Let's meet at the boys' place."

#2 in reply to: ↑ 1 @floffimedia
4 years ago

Replying to miqrogroove:

Excuse my disagreement, but formal grammar in English requires a possessive proper noun to be followed by the letter "s", as in, "Let's meet at Chris's place."

Yes, you're absolutely right. I'm sorry. I had German grammar in mind where my example would have been applicable. Thanks for supplying the fitting illustration.

#3 @miqrogroove
4 years ago

  • Version changed from 4.3.1 to 4.3

wptexturize_primes() introduced at 4.3.0. It gives us a good scaffold on which to hang little fixes like this one. However, a good solution will rely on fixing #18549 first. I am hoping to get that done along with #30531 on the roadmap for 4.5. We're looking at late 4.5 or early 4.6 to get this patched in all cases.

#4 in reply to: ↑ 1 @rmccue
4 years ago

Replying to miqrogroove:

Excuse my disagreement, but formal grammar in English requires a possessive proper noun to be followed by the letter "s", as in, "Let's meet at Chris's place."

(It doesn't affect the ticket, but just want to clarify here: both are acceptable, and it depends on the writing style. Some styles have complex rules around this, but there's no singular rule for English.)

Note: See TracTickets for help on using tickets.