WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#34818 closed defect (bug) (fixed)

Unnecessary abbreviated error message string in has_valid_params()

Reported by: daniel-koskinen's profile Daniel Koskinen Owned by: rmccue's profile rmccue
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: REST API Keywords: has-patch i18n-change
Focuses: Cc:

Description

As mentioned on #core-restapi, commenting as a #polyglot here: while translating, @samikeijonen and @zuige noted that the error message for the has_valid_params function in wp-includes/rest-api/class-wp-rest-request.php is __( 'Invalid param.' ). The included patch fixes this.

Attachments (1)

class-wp-rest-request.php.diff​ (580 bytes) - added by Daniel Koskinen 8 years ago.

Download all attachments as: .zip

Change History (6)

@Daniel Koskinen
8 years ago

This ticket was mentioned in ​Slack in #core-restapi by danielck. ​View the logs.
8 years ago

#2 @swissspidy
8 years ago

  • Keywords has-patch added

#3 @rmccue
8 years ago

  • Keywords i18n-change added

Note that we are in soft string freeze currently, so this may need to wait until 4.5. Need feedback from a polyglot team member here.

#4 @rmccue
8 years ago

  • Milestone changed from Awaiting Review to 4.4

​Checked with Petya, and we're good to change the string. Since this is a new one in 4.4, no qualms from my end with changing it.

#5 @rmccue
8 years ago

  • Owner set to rmccue
  • Resolution set to fixed
  • Status changed from new to closed

In 35750:

REST API: Unabbreviate error string.

Props daniel-koskinen.
Fixes #34818.

Note: See TracTickets for help on using tickets.