Responsive images broken on edited/imported content

[kovshenin]

When we're rendering a srcset for responsive images we're relying on the wp-image-* class name, but the class name may not be consistent with attachment IDs when working with imported content or when editing the src attribute manually. This can result in different images shown on different screen sizes or screen densities.

[kovshenin]

In 34898.diff​: Bail if the original src is not in any of the image sizes.

[azaozz]

Looks good, +1

[joemcgill]

We might be able to streamline things by moving this logic to wp_calculate_image_srcset(), but the patch works and doesn't add any measurable performance overhead. We should add a unit test for this as well.

[kirasong]

As you'd expect, it's slightly slower, but within margin of error for profiling.

+1

[joemcgill]

Adds unit tests

[joemcgill]

Add a unit test in 34898-test.diff.

[wonderboymusic]

+1 on 34898.2.diff

[kirasong]

In 35820:

Media: Don't generate responsive image attributes if src does not match ID in wp-image- class.

We rely on the wp-image- class to quickly find an attachment ID to add responsive image attributes.
To avoid incorrect images being displayed, do not add these attributes if the src does not match the
meta from the attachment ID in the class.

Props azaozz, kovshenin, joemcgill.
Fixes: #34898.

[ocean90]

In 35821:

Media: Don't generate responsive image attributes if src does not match ID in wp-image- class.

We rely on the wp-image- class to quickly find an attachment ID to add responsive image attributes.
To avoid incorrect images being displayed, do not add these attributes if the src does not match the
meta from the attachment ID in the class.

Merge of [35820] to the 4.4 branch.

Props azaozz, kovshenin, joemcgill, mikeschroder.
See #34898.