The "required" title attributes are not translatable in wp-admin/includes/media.php

[andg]

In the wp-admin/includes/media.php file, a few title attributes with an hardcoded value of required (the title is present because the content of those links is just an asterisk) are not translatable.

[andg]

Make the "required" title attributes translatable in wp-admin/includes/media.php

[swissspidy]

Looks good to me. Perhaps strings need context for translators?

[andg]

Something along the line of input fields title attribute, perhaps? Better have context than not, preparing another patch. Thanks for the feedback, @swissspidy!

[andg]

Make the "required" title attributes translatable in wp-admin/includes/media.php, with proper context.

[afercia]

Was struggling a bit trying to find where these title attributes are actually used. Looks like some of them were used in the pre-3.5.0 media upload popup, not sure if still used somewhere, maybe worth checking a bit before introducing new strings? cc @ocean90

Screenshot from WP 3.4:

[SergeyBiryukov]

Replying to afercia:

Was struggling a bit trying to find where these title attributes are actually used. Looks like some of them were used in the pre-3.5.0 media upload popup, not sure if still used somewhere, maybe worth checking a bit before introducing new strings?

The old media UI can be re-enabled with a ​plugin, and I've seen some plugins using it.

Should we perhaps add aria-label in addition to (or instead of) the title attribute?

[afercia]

Replying to SergeyBiryukov:

The old media UI can be re-enabled with a ​plugin, and I've seen some plugins using it.

Then the best thing would probably be mimicking the Comment form and:

• remove the title attribute
• add the sentence "Required fields are marked *" before the form
• move the asterisk inside the labels
• add both aria-required="true" and required on the required fields

[afercia]

First pass with the new approach. Any feedback and improvements welcome :)

[afercia]

Screenshot with an example of the patch applied. The asterisk won't be replaced by the icons but the "no", "OK" and spinner icons will still work:

[ocean90]

I'm voting for a wontfix. The old media UI is … old and we shouldn't encourage people to still using it.

[markoheijnen]

I can see both points. I do think we should fix it. Not to encourage people but to create a better experience if a user is still seeing this. Wasn't this also not enabled if a certain action/filter was used?

[afercia]

Replying to ocean90:

we shouldn't encourage people to still using it.

I see both points but if won't fix, then maybe it should be deprecated? I'd vote to just fix it, it's simpler :)

[kirasong]

I don't see this as a priority, but also don't have a problem with it being fixed. Up to you.

[afercia]

Replying to mikeschroder:

I don't see this as a priority, but also don't have a problem with it being fixed. Up to you.

Refreshed patch. Definitely not a priority, I'd just like to kill all the title attributes :)

[afercia]

In 36879:

Accessibility: Remove the title attributes from the old Media UI.

Also, adds better indication and attributes for the required form fields.
Moves some styles to deprecated-media.css.

Props andg, afercia.
Fixes #34944.