WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 5 months ago

#35002 new enhancement

Attempt to set executable bits for core directories

Reported by: nacin Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords:
Focuses: Cc:
PR Number:

Description

I just diagnosed a problem with a site where wp-includes was 744 rather than 755, missing the executable bit and thus preventing CSS/JS from being served.

Suexec was being used, so we should have had the ability to set the executable bit if we had ever noticed this was a problem.

This happened on an existing site, so I'm not entirely sure when we'd fix this. wp-admin/maint script? DB upgrade process? Core file update process? I'm not sure what caused this here, which would probably play into how to best account for it. (Wordfence was on the site, could have been related.)

I asked @pento about this and he said "One less insane error to deal with is always a nice thing."

Change History (3)

#1 @nacin
4 years ago

  • Type changed from defect (bug) to enhancement

#2 @dd32
4 years ago

And writable bits too.
I just diagnosed another failure as being caused by wp-admin & wp-includes having 0555 permissions (That resulted in the upgrade completing, but it was unable to create new files in those directories, although it updated the existing ones)

Last edited 4 years ago by dd32 (previous) (diff)

#3 @dd32
4 years ago

This happened on an existing site, so I'm not entirely sure when we'd fix this. wp-admin/maint script? DB upgrade process? Core file update process? I'm not sure what caused this here, which would probably play into how to best account for it. (Wordfence was on the site, could have been related.)

My thinking is that we'd do this during the core file update process; Any directories (& files?) which have more restrictive permissions than FS_CHMOD_* would get their permissions reset.
It kind of sucks to make permissions less restrictive when potentially someone explicitly set those, but as we'll be creating new files & directories as it.. I don't see a massive issue there.

Worth noting that these errors mostly come into play with Major updates and not maintenance updates.

Note: See TracTickets for help on using tickets.