Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#35421 closed defect (bug) (fixed)

Default Themes: Fieldset Chrome bug

Reported by: obenland Owned by: obenland
Priority: normal Milestone: 4.5
Component: Bundled Theme Version: 3.6
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Webkit browsers set the min-width of fieldset elements to -webkit-min-content. min-content is the smallest measure that would fit around its content if all soft wrap opportunities within the box were taken.

On small screens it can happen that fieldset contains elements that are wider than the content area, resulting in fieldset overflowing to accommodate those elements. A good example for that is the Elements post on Theme Preview at wp-themes.com.

This bug occurs in 2013, 2014, 2015, and 2016.

Attachments (9)

35421.diff (1.2 KB ) - added by obenland 11 years ago.
2014-before.png (44.3 KB ) - added by obenland 11 years ago.
2014-after.png (46.9 KB ) - added by obenland 11 years ago.
2015-before.png (34.9 KB ) - added by obenland 11 years ago.
2015-after.png (35.1 KB ) - added by obenland 11 years ago.
style.css (66.8 KB ) - added by chris_dev 11 years ago.
35421_2014.diff (291 bytes ) - added by chris_dev 11 years ago.
for twentyfourteen
35421_2015.diff (338 bytes ) - added by chris_dev 11 years ago.
for twentyfifteen
35421_2013.diff (287 bytes ) - added by chris_dev 11 years ago.
for twentythirteen

Download all attachments as: .zip

Change History (17)

@obenland
11 years ago

@obenland
11 years ago

@obenland
11 years ago

@obenland
11 years ago

@obenland
11 years ago

@chris_dev
11 years ago

#1 @chris_dev
11 years ago

  • Keywords has-patch added

@obenland Hi, I tested it with twentysixteen v1.1

I added min-width: inherit; inside of fieldset.

If my solution is correct, I will fix other default theme as well.

@chris_dev
11 years ago

for twentyfourteen

@chris_dev
11 years ago

for twentyfifteen

@chris_dev
11 years ago

for twentythirteen

#2 @iamtakashi
11 years ago

@obeland, thanks for the report and the patch. I'll test them through.

@chris_dev: Thanks, but @obeland has already attached a patch :) And, for the next time, please order property alphabetically for consistency and make your patch from the root.

Last edited 11 years ago by iamtakashi (previous) (diff)

#3 @chris_dev
11 years ago

@iamtakashi sorry for the messy. I should have checked it thoroughly :)

#4 follow-up: @jorbin
11 years ago

@iamtakashi how does this look? Commit or punt?

#5 @jorbin
11 years ago

  • Owner set to iamtakashi
  • Status newassigned

#6 in reply to: ↑ 4 @iamtakashi
11 years ago

Replying to jorbin:

@iamtakashi how does this look? Commit or punt?

Thanks for the reminder.

Looks good to me and I didn't see any negative consequence in my testing. Let's get this in! Thanks @obenland.

#7 @obenland
11 years ago

  • Owner changed from iamtakashi to obenland
  • Status assignedaccepted

#8 @obenland
11 years ago

  • Resolutionfixed
  • Status acceptedclosed

In 36875:

Bundled Themes: Prevent elements within fieldsets from overflowing in Webkit.

Fixes #35421.

Note: See TracTickets for help on using tickets.