Separate unit test factory classes into separate files

[ericlewis]

Similar to the spirit of #33413, I suggest we split unit test factory classes into their own files for readability purposes.

[swissspidy]

I found that quite annoying when I had to look up some methods of the factories, so +1.

[netweb]

Related: #30017

[ericlewis]

As this will be a somewhat large change, I'd like to propose the solution before putting together a patch.

Split out classes into a new folder tests/phpunit/includes/factory/, which will include

class-wp-unittest-factory-for-post.php
class-wp-unittest-factory-for-attachment.php
class-wp-unittest-factory-for-user.php
class-wp-unittest-factory-for-comment.php
class-wp-unittest-factory-for-blog.php
class-wp-unittest-factory-for-network.php
class-wp-unittest-factory-for-term.php
class-wp-unittest-factory-for-thing.php
class-wp-unittest-generator-sequence.php
class-wp-unittest-factory-callback-after-create.php

then require_once each of these ​in `bootstrap.php`.

Does that sound good?

[boonebgorges]

Plan sounds good to me.

When creating the new files, make sure to use svn cp so that we don't lose revision history.

[ericlewis]

Replying to ericlewis:

[The plan is to split] out classes into a new folder [...] then require_once each of these ​in `bootstrap.php`.

Actually, for backwards compatibility, we should require_once these in factory.php, where I've left the main class WP_UnitTest_Factory.

Proposed patch in attachment:35492.diff​.

[ericlewis]

In 36347:

Build/Test Tools: Move PHP factory classes into their own files.

This makes the code easier to browse.

factory.php loads the new files, so this is backwards compatible in case factory.php is loaded directly for access to one of the classes.

See #35492.

[ericlewis]

Should we move class WP_UnitTest_Factory into its own file as well?

[ericlewis]

Replying to ericlewis:

Should we move class WP_UnitTest_Factory into its own file as well?

Yes, I think so.

[ericlewis]

Missed the ticket, r36409 moves class WP_UnitTest_Factory into its own file.