WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#35565 closed enhancement (fixed)

Functions ending brace should be on a newline.

Reported by: georgestephanis Owned by: SergeyBiryukov
Priority: low Milestone: 4.5
Component: Media Version: 4.0
Severity: minor Keywords: has-patch
Cc: Focuses:

Description

The _wp_handle_upload() function for a while now has had its ending brace on the same line as its return statement. This makes the code really hard to skim and is kinda ugly.

I'd like to see us rectify that and move it to its rightful place, as emperor of its own sovereign line of succession.

Patch attached.

Attachments (1)

35565.diff​ (503 bytes ) - added by georgestephanis 11 years ago.

Download all attachments as: .zip

Change History (6)

@georgestephanis
11 years ago

#1 @ericlewis
11 years ago

  • Type defect (bug) → enhancement

Although ​we don't usually refactor just because, this seems far off enough from our coding standards to warrant fixing.

#2 @ericlewis
11 years ago

  • Milestone Awaiting Review → 4.5

#3 @SergeyBiryukov
11 years ago

  • Component General → Media

#4 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 36373:

Media: In _wp_handle_upload(), move ending brace to a new line.

Props georgestephanis.
Fixes #35565.

#5 @johnbillion
11 years ago

  • Version trunk → 4.0
Note: See TracTickets for help on using tickets.