WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#35665 closed task (blessed) (fixed)

Update the Random_Compat external library

Reported by: dd32 Owned by: dd32
Milestone: 4.5 Priority: low
Severity: minor Version:
Component: External Libraries Keywords:
Focuses: Cc:

Description

I'm leaving this ticket open for the 4.5 cycle to track updating the Random_Compat external library.

Version 1.1.6 was just released.

To update, I normally just pull in the master from Github and commit that directly. Care should be taken that the diff only contains the fixes from the release. You can also check out from the tag or download the release from Github.

svn export https://github.com/paragonie/random_compat/trunk/lib/ src/wp-includes/random_compat/ --force

Change History (6)

#1 @dd32
5 years ago

In 36421:

Update Random_Compat to the latest version (1.1.6).

See #35665

#2 @dd32
5 years ago

  • Owner set to dd32
  • Status changed from new to accepted
  • Summary changed from Update Random_Compat to Update the Random_Compat external library

#3 @ocean90
5 years ago

Related: #35970, probably have to update to 1.2(.1)

#4 @ocean90
5 years ago

In 36886:

Update Random_Compat from 1.1.6 to 1.2.1.

Changes: https://github.com/paragonie/random_compat/compare/1.1.6...v1.2.1

See #35665.

#5 @ocean90
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Going to close this as fixed. Ticket can be reopened in case another update happens, which is currently not planned.

#6 @sagalbot
3 years ago

This library appears to be out of date - running php -l against these files in a PHP7 environment will trigger syntax errors. This was fixed October 2016 https://github.com/paragonie/random_compat/commit/1788eb294e9f2016045d6e2d202530b48d77671c.

WPEngine runs php -l against all files when you are deploying with git push, and if syntax errors are found, you cannot push. Currently, I can't push my projects to a PHP71 WPEngine server, because php -l fails on all of the files from this package, as they are out of date with the latest changes.

Note: See TracTickets for help on using tickets.