Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#35748 closed defect (bug) (wontfix)

Avoid using HTML tags in translation strings (wp-admin/includes/dashboard.php)

Reported by: ramiy's profile ramiy Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

See the attached patch.

Remove two <a> HTML tags from translation strings and add esc_url() to a string with codex URL.

Attachments (1)

35748.patch (2.0 KB) - added by ramiy 9 years ago.

Download all attachments as: .zip

Change History (6)

@ramiy
9 years ago

#1 @ramiy
9 years ago

  • Keywords has-patch added

#2 @ramiy
9 years ago

Old string:

  • Manage <a href="%1$s">widgets</a> or <a href="%2$s">menus</a>

New strings:

  • Manage %1$s or %2$s
  • widgets
  • menus

No HTML tags, much easier to translate.

#3 @ocean90
9 years ago

much easier to translate.

I disagree because now I have to check why I need to translate two single, lower cased words and in what context they are used.
Same for the placeholders because the translator comment only mentions " widget/menus link".

Last edited 9 years ago by ocean90 (previous) (diff)

#4 @ramiy
9 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

#5 @netweb
9 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.