Opened 5 years ago
Last modified 20 months ago
#35880 new enhancement
Refactor date handling in wp_insert_post()
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Posts, Post Types | Keywords: | has-patch |
Focuses: | Cc: |
Description
I started refactoring this code while researching #35874, because I thought the unpredictable logic in this function might have contributed to the problems described there. Although that turned out not to be the case, I think the refactoring I've done is still valuable. Effectively I've aimed to clarify the code by leaning heavily on standardizing the validation of submitted dates into the $post_date variable, and then converting that back to a GMT based $post_date_gmt only when all other shared validation is completed.
In my opinion this makes the code easier to read and maintain, but as this doesn't specifically address any known bug, I will appreciate it if it doesn't seem worth integrating.
Refactor wp_insert_post()'s handling of dates to be more readable and maintainable