Opened 9 years ago
Closed 3 years ago
#35880 closed enhancement (duplicate)
Refactor date handling in wp_insert_post()
Reported by: | redsweater | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Posts, Post Types | Keywords: | has-patch |
Focuses: | Cc: |
Description
I started refactoring this code while researching #35874, because I thought the unpredictable logic in this function might have contributed to the problems described there. Although that turned out not to be the case, I think the refactoring I've done is still valuable. Effectively I've aimed to clarify the code by leaning heavily on standardizing the validation of submitted dates into the $post_date variable, and then converting that back to a GMT based $post_date_gmt only when all other shared validation is completed.
In my opinion this makes the code easier to read and maintain, but as this doesn't specifically address any known bug, I will appreciate it if it doesn't seem worth integrating.
Attachments (1)
Change History (5)
#4
@
3 years ago
- Resolution set to duplicate
- Status changed from new to closed
Thanks for the patch @redsweater and sorry it's taken so long for someone to respond. Looks like the code in question has been heavily refactored since your patch (e.g. in #52187), and now includes many of the improvements you proposed. As such I'm going to close this ticket.
Refactor wp_insert_post()'s handling of dates to be more readable and maintainable