WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#36017 closed defect (bug) (fixed)

Add Device Preview to the Theme-install Previewer

Reported by: celloexpressions Owned by: ocean90
Priority: normal Milestone: 4.5
Component: Themes Version: 4.6
Severity: normal Keywords: has-patch has-screenshots
Cc: Focuses: ui

Description

The theme-install previewer uses the same UI framework as the customizer, and allows themes to be previewed with generic content from wordpress.org. We should bring the device preview buttons in the customizer to this interface as well, so that themes can be easily previewed on various device sizes before being installed.

Attachments (3)

36017.diff​ (8.3 KB ) - added by celloexpressions 11 years ago.
theme-install-device-preview.gif​ (2.1 MB ) - added by celloexpressions 11 years ago.
With 36017.diff​.
36017.2.diff​ (8.9 KB ) - added by ocean90 11 years ago.

Change History (6)

@celloexpressions
11 years ago

@celloexpressions
11 years ago

With 36017.diff​.

#1 @celloexpressions
11 years ago

Note that the patch moves the CSS to themes.css and adjusts selectors so that it can be used for both versions. Also, the available devices are intentionally not customizable in this UI, since plugins are generally restricted from doing much to this interface directly.

#2 @kirasong
11 years ago

  • Owner set to ocean90
  • Status new → assigned
  • Type enhancement → defect (bug)

Changing this to bug, since it's something caught that was missed in #31195.

@ocean90
11 years ago

#3 @ocean90
11 years ago

  • Resolution → fixed
  • Status assigned → closed

In 36858:

Themes: Bring the device preview from [31195] to the theme install previewer.

Props celloexpressions.
Fixes #36017.

Note: See TracTickets for help on using tickets.