wpdb set_sql_mode add param

[spacedmonkey]

When making a creating a db drop-in that supports multiple databases, I had to override the whole set_sql_mode method. If set_sql_mode accepted a $dbh param, the method could easily be reused.

This change allows specifying a database handle when setting SQL mode, providing more flexibility in handling different database connections. It defaults to using the existing class property if no argument is passed. This ensures backward compatibility while enhancing functionality.

[pbearne]

refresh patch

[flixos90]

Since it is possible to extend wpdb in a drop-in, changing the method signature of the public set_sql_mode() method would be a breaking change for any drop-in that already extends this method. Some very popular plugins appear to do that, see ​https://wpdirectory.net/search/01JHNCFYTVV0JJA4BA56ZRJMTC.

Based on this, I think this should be closed. If there is a very good justification to introduce this breaking change here, we can reconsider, but the argument of more developer convenience is not sufficient to do that I think.

[swissspidy]

Also not really a performance related change, so removing the focus.

[spacedmonkey]

@swissspidy @flixos90 The issue here is that hyperdb and ludicrousdb both extend this method to do this. But when this method is called in other parts of the class, this parameter is not passed, meaning that LOTS of the class has to be override to support overriding this class. Adding this parameter making it much easier to override and testing against core updates easier too. It also makes the code much more testable.

CC @johnjamesjacoby for his thoughts as well.