Incorrect use of E_USER_NOTICE in wpdb::_real_escape()

[SergeyBiryukov]

in wpdb::_real_escape()​, the last parameter for _doing_it_wrong() calls is E_USER_NOTICE, which leads to the following message:

wpdb must set a database connection for use with escaping. This message was added in version 1024.

It was apparently influenced by ​trigger_error(). For ​_doing_it_wrong(), however, the last parameter should be the version of WordPress where the message was added, i.e. '3.6'.

Introduced in [24758].

[andizer]

Just added a patch for this.

[pento]

Thanks for the patch, @andizer! It shouldn't be $wp_version, we need to pass the WordPress version where this error message was introduced - in this case, version 3.6.

[andizer]

Thank you for your comment. I was too quick in writing the patch, should have read the issue better. I've updated the patch.

[andizer]

Update patch

[DrewAPicture]

Assigning to mark the good-first-bug as "claimed".

[SergeyBiryukov]

In 38133:

Database: Replace incorrect use of E_USER_NOTICE in wpdb::_real_escape() with the version number where the message was added.

Props andizer.
Fixes #36403.