wp_delete_attachment causes warning

[thorbrink]

wp_delete_attachment assumes that attachments uses category and post_tag taxonomies. This causes a warning in wp_delete_object_term_relationships when post type attachment is not using category or post_tag taxonomies.

[desrosj]

Hi @thorbrink, would you be able and interested in adding unit tests for this?

Trac Ticket: Core-36437

## Description:

• This pull request addresses an issue with the wp_delete_attachment function, which assumes that attachments use the category and post_tag taxonomies. This assumption can lead to warnings in wp_delete_object_term_relationships when the attachment's post type does not utilize these taxonomies.

## Changes Made:

• Updated the wp_delete_attachment function to check for existing taxonomies associated with the post type. This ensures that only relevant taxonomies are used when deleting term relationships, preventing unnecessary warnings.

• Removed hardcoded references to category and post_tag, allowing the function to dynamically handle any taxonomies related to the attachment's post type.

• Added unit tests to verify the new behavior, ensuring that attachments can be deleted without warnings even when custom taxonomies are used. The tests confirm that the function behaves correctly when no terms are associated with the attachment.

## Testing:

• All existing and new unit tests have been executed successfully, confirming that the changes do not introduce any regressions and that the new functionality works as intended.

## Conclusion:

• These changes enhance the robustness of the wp_delete_attachment function, making it more flexible and ensuring it can handle a wider range of use cases without generating warnings. Thank you for considering this pull request!