![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 10 years ago
Closed 8 years ago
#36589 closed defect (bug) (duplicate)
Don't use localhost in Tests_Image_Header tests
| Reported by: | ocean90 | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Customize | Version: | 3.9 |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: |
Description (last modified by )
Tests_Image_Header::test_create_attachment_object() and Tests_Image_Header::test_insert_cropped_attachment() are passing http://localhost/foo-cropped.png to Custom_Image_Header::create_attachment_object(). This method is using getimagesize() for the URL. I'm not sure if this a config issue but it seems like the timeout is pretty high so the tests are taking a minute to complete.
Output of PHPunit:
1) Tests_Image_Header::test_create_attachment_object ImagickException: getimagesize(http://localhost/foo-cropped.png): failed to open stream: Connection refused src/wp-admin/custom-header.php:1160 tests/phpunit/tests/image/header.php:116 2) Tests_Image_Header::test_insert_cropped_attachment ImagickException: getimagesize(http://localhost/foo-cropped.png): failed to open stream: Connection refused src/wp-admin/custom-header.php:1160 tests/phpunit/tests/image/header.php:132
Change History (6)
This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.
10 years ago
Note:
See TracTickets
for help on using tickets.
+1, can someone make a patch? This was presumably introduced in 3.9.