WordPress.org

Make WordPress Core

Opened 18 months ago

Last modified 13 months ago

#36589 new defect (bug)

Don't use localhost in Tests_Image_Header tests

Reported by: ocean90 Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.9
Component: Customize Keywords: needs-patch
Focuses: Cc:

Description (last modified by ocean90)

Tests_Image_Header::test_create_attachment_object() and Tests_Image_Header::test_insert_cropped_attachment() are passing http://localhost/foo-cropped.png to Custom_Image_Header::create_attachment_object(). This method is using getimagesize() for the URL. I'm not sure if this a config issue but it seems like the timeout is pretty high so the tests are taking a minute to complete.

Output of PHPunit:

1) Tests_Image_Header::test_create_attachment_object
ImagickException: getimagesize(http://localhost/foo-cropped.png): failed to open stream: Connection refused

src/wp-admin/custom-header.php:1160
tests/phpunit/tests/image/header.php:116

2) Tests_Image_Header::test_insert_cropped_attachment
ImagickException: getimagesize(http://localhost/foo-cropped.png): failed to open stream: Connection refused

src/wp-admin/custom-header.php:1160
tests/phpunit/tests/image/header.php:132

Change History (5)

#1 @ocean90
18 months ago

  • Description modified (diff)

#2 @celloexpressions
18 months ago

  • Milestone changed from Awaiting Review to Future Release

This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.


13 months ago

#4 @celloexpressions
13 months ago

  • Version set to 3.9

+1, can someone make a patch? This was presumably introduced in 3.9.

#5 @stevenlinx
13 months ago

sry., what URLs do you propose to use instead?

Note: See TracTickets for help on using tickets.