Make WordPress Core

Opened 8 years ago

Closed 6 years ago

#36596 closed enhancement (invalid)

add config option to auto upgrade even if installed in VCS

Reported by: greggman's profile greggman Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.6
Component: Upgrade/Install Keywords:
Focuses: Cc:


Currently auto-upgrade doesn't work if it detects a VCS. I'd like to add a config option to have it ignore that.

Would that be ok?

I'd put it in wp-admin/includes/class-wp-upgrader.php probably near like 2750

public function is_vcs_checkout

And just have it return false if some config option is set

Any preference for the name? Maybe AUTOMATIC_UPDATER_IGNORE_VCS

Change History (2)

#1 @swissspidy
8 years ago

I don't really see the need for another constant for this. There's already the automatic_updates_is_vcs_checkout filter.

Can you elaborate a bit on why you need this, and the benefit over using the filter?

add_filter( 'automatic_updates_is_vcs_checkout', '__return_false' ); is a one-liner. It can't get easier than that.

#2 @dd32
6 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Closing in preference for existing filter.

Note: See TracTickets for help on using tickets.