WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#36604 closed defect (bug) (fixed)

Emoji skin tone support test incorrectly passing in Chrome

Reported by: pento Owned by: pento
Milestone: 4.5.1 Priority: normal
Severity: normal Version: 4.5
Component: Emoji Keywords: fixed-major
Focuses: javascript Cc:
PR Number:

Description

Chrome 50 fixed a bunch of their emoji rendering bugs, but emoji skin tone wasn't one of them.

Unfortunately, our skin tone test is incorrectly passing, we should figure out why.

Change History (4)

#1 @pento
4 years ago

  • Milestone changed from 4.6 to 4.5.1
  • Owner set to pento
  • Status changed from new to assigned
  • Version set to 4.5

#2 @pento
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37256:

Emoji: The diversity support test was incorrectly passing on all browsers.

[37028] missed some logic to capture the base emoji skin tone, to compare to the modified emoji skin tone. This caused all browsers to report that they supported skin tone modifiers, regardless of whether they actually did.

Fixes #36604 for trunk.

#3 @pento
4 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#4 @pento
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 37257:

Emoji: The diversity support test was incorrectly passing on all browsers.

[37028] missed some logic to capture the base emoji skin tone, to compare to the modified emoji skin tone. This caused all browsers to report that they supported skin tone modifiers, regardless of whether they actually did.

Merge of [37256] to the 4.5 branch.

Fixes #36604.

Note: See TracTickets for help on using tickets.