WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#36793 closed defect (bug) (fixed)

Customizer doesn't load in IE8

Reported by: ocean90 Owned by: westonruter
Milestone: 4.5.3 Priority: normal
Severity: normal Version: 4.5
Component: Customize Keywords: has-patch commit fixed-major
Focuses: javascript Cc:

Description

Error message:

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0)
Timestamp: Mon, 9 May 2016 20:28:34 UTC

Message: Expected identifier
Line: 1454
Char: 7
Code: 0
URI: http://develop.wp.dev/wp-includes/js/underscore.js?ver=1.8.3

Attachments (2)

36793.png (30.8 KB) - added by ocean90 3 years ago.
36793.diff (795 bytes) - added by adamsilverstein 3 years ago.

Download all attachments as: .zip

Change History (14)

@ocean90
3 years ago

#1 @ocean90
3 years ago

Previously: #30781

#2 @ocean90
3 years ago

  • Version set to 4.5

#3 @westonruter
3 years ago

We need to get the QUnit tests running on BrowserStack so that these IE8 issues can be caught automatically.

#4 @adamsilverstein
3 years ago

Digging into this, so far I have discovered this is theme related. Activating an older theme the customizer loads without error in ie8.

Last edited 3 years ago by adamsilverstein (previous) (diff)

#5 @adamsilverstein
3 years ago

  • Keywords has-patch commit added; needs-patch removed
  • Owner set to westonruter
  • Status changed from new to assigned

In 36793.diff:

  • Remove use of reserved word default in Underscore template which breaks IE8.

This code was introduced in r30712 and is inclass-wp-customize-media-control.php - not sure why this cropped up in 4.5 specifically, perhaps something in the customizer load sequence is now using the media control (site logo?) that wasn't previously being used.

This change fixes the issue. Screenshot showing no errors in customizer in IE8:

http://cl.ly/3b0u1E1D1M35/Dashboard_2016-05-11_10-27-16.jpg

#6 @westonruter
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37417:

Customize: Remove use of reserved word default in Underscore template which breaks IE8.

Fixes regression introduced in r30712.

Props adamsilverstein.
Fixes #36793.

#7 @westonruter
3 years ago

  • Keywords fixed-major added
  • Milestone changed from Awaiting Review to 4.5.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening for consideration for 4.5.3

#8 @ocean90
3 years ago

@adamsilverstein [36769] was the breaking change for 4.5.

#9 follow-up: @adamsilverstein
3 years ago

@ocean90 aha that makes more sense. I was using Svn blame, how did you find the breaking change?

This ticket was mentioned in Slack in #core by adamsilverstein. View the logs.


3 years ago

#12 @ocean90
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 37450:

Customize: Remove use of reserved word default in Underscore template which breaks IE8.

Fixes regression introduced in [36769].

Merge of [37417] to the 4.5 branch.

Props adamsilverstein.
Fixes #36793.

Note: See TracTickets for help on using tickets.