WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 6 months ago

#36898 new defect (bug)

Have `grunt precommit` fail if the test DB is unreachable.

Reported by: peterwilsoncc Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: needs-patch
Focuses: Cc:

Description

grunt precommit passes if the test DB is unreachable, preventing phpunit from running.

To recreate:

  1. Disable your local database
  2. Add a test guaranteed to fail
  3. Run grunt precommit
  4. The result will be Done, without errors.

This could happen in the hypothetical event someone forgets to start their virtual machine.

Change History (1)

#1 @ocean90
3 years ago

💯

The HHVM build is currently passing although there seems to be a database issue, see https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/174664244.

Note: See TracTickets for help on using tickets.