Make WordPress Core

Opened 8 years ago

Last modified 17 months ago

#36971 accepted enhancement

Show readme.txt from Themes

Reported by: zodiac1978's profile zodiac1978 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Themes Keywords:
Focuses: ui Cc:

Description

The readme.txt should be used to document any dependencies of a theme. But if we install the theme from inside WordPress there is no way to see the readme.txt for an unexperienced user.

For example the Sela theme needs Jetpack to show Testimonials.
See readme.txt: https://themes.svn.wordpress.org/sela/1.0.9/readme.txt

But the theme page is not mentioning that (https://wordpress.org/themes/sela/) and there is no direct link or presentation of the readme.txt with this essential information on the theme page or inside WordPress.

I suggest showing the readme.txt somewhere or use a system like https://github.com/TGMPA/TGM-Plugin-Activation to give this information to the user.

Change History (45)

#1 @jcastaneda
8 years ago

There is one that was opened three years ago: #22810

And one for meta as well:
https://meta.trac.wordpress.org/ticket/45

Last edited 5 years ago by SergeyBiryukov (previous) (diff)

#2 @ocean90
8 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed
  • Version trunk deleted

For changelogs see #22810 and #meta45, for displaying the data see #25707 and #meta215.

Going to close this as maybelater since a readme.txt is currently not a requirement and it doesn't seem like there is a standard yet. This should be discussed with the theme review team first.

#3 follow-up: @zodiac1978
8 years ago

I suggest re-opening, because #meta215 is for the Theme directory and #meta45 is for changelogs. What is about showing readme.txt in WordPress core (/wp-admin/themes.php)?

#4 @zodiac1978
8 years ago

  • Resolution maybelater deleted
  • Status changed from closed to reopened

#5 in reply to: ↑ 3 ; follow-up: @ocean90
8 years ago

  • Resolution set to maybelater
  • Status changed from reopened to closed

Replying to zodiac1978:

I suggest re-opening, because #meta215 is for the Theme directory and #meta45 is for changelogs. What is about showing readme.txt in WordPress core (/wp-admin/themes.php)?

Changelogs are probably part of the readme.txt. But still, my main reason was:

… a readme.txt is currently not a requirement and it doesn't seem like there is a standard yet. This should be discussed with the theme review team first.

We can't display something that doesn't exist and/or has a proper specification.

#6 in reply to: ↑ 5 @zodiac1978
8 years ago

Replying to ocean90:

We can't display something that doesn't exist and/or has a proper specification.

Couldn't we check if a readme.txt exists and if it does, show it completely in a (disabled/non-editable) textarea?

#7 @zodiac1978
7 years ago

If you don't want to wait for a solution on wp.org, there is a plugin for showing at least the changelogs:
https://wordpress.org/plugins/wp-theme-changelogs/

Last edited 7 years ago by zodiac1978 (previous) (diff)

#8 follow-up: @zodiac1978
6 years ago

Themes are recommended to include a readme.txt file, using plugin directory’s readme.txt markdown format. This recommendation will soon become required.

https://developer.wordpress.org/themes/release/writing-documentation/

Maybe this ticket could be revisited if a readme.txt is required.

I'm still convinced that we are violating the attribution requirement if we hide those attributions in a readme.txt which is not shown to any backend user.

Declare licenses of any resources included such as fonts or images.

This requirement from the theme team is typically handled through a readme.txt.

This ticket was mentioned in Slack in #meta by sergey. View the logs.


5 years ago

This ticket was mentioned in Slack in #themereview by joyously. View the logs.


5 years ago

This ticket was mentioned in Slack in #themereview by joyously. View the logs.


5 years ago

This ticket was mentioned in Slack in #design by boemedia. View the logs.


5 years ago

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by joyously. View the logs.


5 years ago

#15 in reply to: ↑ 8 @joyously
5 years ago

  • Resolution maybelater deleted
  • Status changed from closed to reopened

Replying to zodiac1978:

Maybe this ticket could be revisited if a readme.txt is required.

The readme.txt file is required as of Oct 25, 2018.

https://make.wordpress.org/themes/handbook/review/required/#readme-txt-file

#16 @SergeyBiryukov
5 years ago

  • Milestone set to Awaiting Review

This ticket was mentioned in Slack in #design by joyously. View the logs.


5 years ago

This ticket was mentioned in Slack in #design by joyously. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by joyously. View the logs.


4 years ago

This ticket was mentioned in Slack in #meta by joyously. View the logs.


4 years ago

#21 @SergeyBiryukov
4 years ago

  • Keywords needs-design added

Per https://meta.trac.wordpress.org/ticket/215#comment:42, this needs design both for theme pages on WordPress.org and for theme modals in core. Adding the keyword.

This ticket was mentioned in Slack in #themereview by joyously. View the logs.


3 years ago

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


3 years ago

This ticket was mentioned in Slack in #themereview by joyously. View the logs.


3 years ago

This ticket was mentioned in Slack in #design by paaljoachim. View the logs.


3 years ago

#26 @mapk
3 years ago

This was recently discussed in a [Design Team feedback session in Slack]https://wordpress.slack.com/archives/C02S78ZAL/p1602696169288400.

While redesigning the theme modals in wp-admin or redesigning the theme detail page on w.org to display the readme text would be great, an interim solution might be the way to go right now.

How about adding a link in the "Browse code" section on the theme details page?

http://cldup.com/y8IsCeftFi.png

And then linking to the detail page on w.org from the theme modal in wp-admin.

http://cldup.com/IS7uGhBzVx.png

This ticket was mentioned in Slack in #core by joyously. View the logs.


3 years ago

This ticket was mentioned in Slack in #meta by joyously. View the logs.


3 years ago

This ticket was mentioned in Slack in #core by joyously. View the logs.


2 years ago

#30 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 5.9

Moving to the milestone to implement comment:26.

This ticket was mentioned in Slack in #core by chaion07. View the logs.


2 years ago

#32 @chaion07
2 years ago

  • Milestone changed from 5.9 to Future Release

Hi @zodiac1978! Thank you for reporting this. This ticket was discussed during a recent Bug-scrub session. Based on the feedback received we're updating the ticket with milestone being changed. The feature freeze date is inching close so this needs a patch. Thus requesting attention from contributors if possible. Thanks!

This ticket was mentioned in Slack in #themereview by joyously. View the logs.


2 years ago

This ticket was mentioned in Slack in #core by joyously. View the logs.


2 years ago

#35 @SergeyBiryukov
2 years ago

  • Milestone changed from Future Release to 6.0

#36 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Status changed from reopened to accepted

This ticket was mentioned in Slack in #design by chaion07. View the logs.


2 years ago

This ticket was mentioned in Slack in #design by chaion07. View the logs.


2 years ago

#39 @chaion07
2 years ago

  • Keywords needs-design removed

We reviewed this ticket during a recent bug-scrub session. Mark's comment actually covers the design feedback. So we are removing the keyword.

Props to @joyously for pointing this out.

Cheers!

This ticket was mentioned in Slack in #core by chaion07. View the logs.


2 years ago

#41 @chaion07
2 years ago

  • Milestone changed from 6.0 to Future Release

Thanks @zodiac1978 for reporting this. With Beta 01 coming into effect by the end of today and with the lack of progress we are updating the milestone on this ticket to Future Release. Cheers!

This ticket was mentioned in Slack in #core by sergey. View the logs.


20 months ago

This ticket was mentioned in Slack in #core by sergey. View the logs.


20 months ago

This ticket was mentioned in Slack in #core by sergey. View the logs.


20 months ago

This ticket was mentioned in Slack in #core by sergey. View the logs.


17 months ago

Note: See TracTickets for help on using tickets.