WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#37092 closed defect (bug) (fixed)

Undo keyboard shortcut not working properly with the code formatting shortcut

Reported by: eclare Owned by: iseulde
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.5
Component: TinyMCE Keywords: has-patch
Focuses: accessibility, javascript Cc:

Description

When using the new code (backticks) formatting shortcut (related: #33300), the undo keyboard shortcut (Ctrl+Z on Windows) doesn't work as intended: it changes the text back to `foo` but then the text changes back to being an applied code formatting shortcut.

Attachments (2)

37092.patch (733 bytes) - added by iseulde 5 years ago.
37092.2.patch (907 bytes) - added by iseulde 5 years ago.

Download all attachments as: .zip

Change History (6)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


5 years ago

#2 @afercia
5 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Version changed from 4.5.2 to 4.5

Thanks for the ticket @eclare. Reproduced consistently on trunk using different browsers on different platforms: the Undo button works, the shortcut Cmd/Ctrl+z doesn't.
On 4.5.3 sometimes works... specifically it worked for me on a previous version of Chrome (49) on Windows.

@iseulde
5 years ago

#3 @iseulde
5 years ago

  • Keywords has-patch added
  • Milestone changed from Future Release to 4.7

@iseulde
5 years ago

#4 @iseulde
5 years ago

  • Owner set to iseulde
  • Resolution set to fixed
  • Status changed from new to closed

In 39077:

TinyMCE: wptextpattern: Fix undo shortcut for inline patterns

Fixes #37092.

Note: See TracTickets for help on using tickets.