Unit tests for xmlrpc_getposttitle() and xmlrpc_getpostcategory() along with patch to trim and unique returned values

[pbearne]

In tonight's Contrib 2 core we created this unit test for xmlrpc_getposttitle() function

[pbearne]

Unit tests

[pbearne]

these tests just show what is does today

It not very clever and doesn't handle bad data well

If you would nice to update this function but we aren't sure if it worth it

Please ask if you would the function to update

Paul

[pbearne]

functions.php and unit tests

[pbearne]

Having looked at this a bit more we saw that these function can return values that are not trimmed.

So as well as adding unit tests for xmlrpc_getpostcategory() we have changed the functions to return trimmed values

[desrosj]

Hi @pbearne,

Sorry that this ticket fell through the cracks. I am assigning this to myself to review and evaluate.

[pbearne]

I had forgotten about this

If it needs a refresh just ask

[SergeyBiryukov]

Related: #49905

[hellofromTonya]

Adding the notes from @SergeyBiryukov from today's scrub:

I think these tests could also be converted to use a data provider instead of a bunch of separate functions.
I'll try to refresh and commit before beta or punt otherwise

[pbearne]

updated patch data providers

[pbearne]

Refreshed :-)

[desrosj]

Related: #35993.

Looks like #35993 tries to address the two functions here, as well as the xmlrpc_removepostdata() method. There is also some discussion over there and a patch. Just noting so that the approaches can be compared when evaluated.

Would be nice to also address xmlrpc_removepostdata() so that the other ticket can be fully closed out.

[pbearne]

added xmlrpc_removepostdata

[pbearne]

changed xmlrpc_getpostcategory to use the default_category set in options

[pbearne]

OK lets see if that will close both tickets

Note xmlrpc_getpostcategory got some love as well as the tests

[SergeyBiryukov]

Didn't get a chance to review this in time for 5.6 Beta 1, moving to the next release for now.

[hellofromTonya]

5.7 Beta 1 is tomorrow. Moving this ticket to 5.8 as there's been no activity since punted from 5.6.

If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.