Make WordPress Core

Opened 10 years ago

Closed 6 years ago

Last modified 6 years ago

#37117 closed defect (bug) (fixed)

Upgrade QUnit to 2.9.x

Reported by: jorbin Owned by: SergeyBiryukov
Priority: normal Milestone: 5.5
Component: Build/Test Tools Version:
Severity: normal Keywords: 2nd-opinion has-patch
Cc: Focuses:

Description

QUnit 2.0.0 has been released. There is a upgrade guide to assist in the migration.

Attachments (1)

37117.diff (408.9 KB ) - added by SergeyBiryukov 6 years ago.

Download all attachments as: .zip

Change History (8)

#1 @desrosj
9 years ago

  • Summary Upgrade QUnit to 2.0.0Upgrade QUnit to 2.3.2

The current version of QUnit is now 2.3.2.

#2 @Presskopp
7 years ago

2.9.2
trentmwillis released this 19 days ago · 4 commits to master since this release

See
https://github.com/qunitjs/qunit/releases

#3 @pento
7 years ago

  • Keywords 2nd-opinion added

Is there anything in newer versions of QUnit that we particularly need? The QUnit tests really haven't evolved or expanded in recent years.

Alternatively, Gutenberg has a well developed test library based on Jest, and exports all of the config as a package we could use. In the interest of standardising, perhaps the better option would be migrate our existing QUnit tests to work in Jest, instead.

@SergeyBiryukov
6 years ago

#4 @SergeyBiryukov
6 years ago

  • Keywords has-patch added
  • Milestone Awaiting Review5.5
  • Owner set to SergeyBiryukov
  • Status newaccepted
  • Summary Upgrade QUnit to 2.3.2Upgrade QUnit to 2.9.x

While migrating our existing QUnit tests to work in Jest seems like good idea, updating to the latest QUnit seemed like a good first step for me to get more familiar with them. Started this as an experiment, which turned out to be successful.

In 37117.diff:

Last edited 6 years ago by SergeyBiryukov (previous) (diff)

#5 @SergeyBiryukov
6 years ago

  • Resolutionfixed
  • Status acceptedclosed

In 47512:

Build/Test Tools: Update QUnit and Sinon to the latest versions.

Update JS tests per the QUnit 2.x Upgrade Guide.

Fixes #37117.

#6 @SergeyBiryukov
6 years ago

In 48977:

Build/Test Tools: Remove unused legacy globals from JSHint config for QUnit.

Follow-up to [47512].

Props TimoTijhof.
Fixes #51312. See #37117.

#7 @SergeyBiryukov
6 years ago

In 48978:

Build/Test Tools: Restore the QUnit global in JSHint config for QUnit.

Follow-up to [47512], [48977].

See #51312, #37117.

Note: See TracTickets for help on using tickets.