Make WordPress Core

Opened 10 years ago

Last modified 7 years ago

#37219 new enhancement

Admin menu with admin_url function

Reported by: sebastianpisula's profile sebastian.pisula Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

I think that options in menu should have admin_url function. For example I want add custom param (?lang=de). I can use admin_url filter but this not work in menu items

Attachments (2)

37219.patch (3.4 KB) - added by sebastian.pisula 10 years ago.
37219.2.patch (3.1 KB) - added by sebastian.pisula 10 years ago.
4.7-alpha-38345

Download all attachments as: .zip

Change History (10)

@sebastian.pisula
10 years ago

4.7-alpha-38345

This ticket was mentioned in Slack in #core by sebastian.pisula. View the logs.


10 years ago

#2 @SergeyBiryukov
10 years ago

  • Component changed from Menus to Administration
  • Milestone changed from Awaiting Review to 4.7

#3 @claudiosanches
10 years ago

  • Keywords has-patch added

#4 @jorbin
10 years ago

@helen How do you think this fits in with the larger admin menu changes? Think this is something we can commit to now?

This ticket was mentioned in Slack in #core by aaroncampbell. View the logs.


10 years ago

#6 @aaroncampbell
10 years ago

We push the use of full URL links pretty much everywhere. Seems odd that we don't use them here. Having said that, my main concern is what can $submenu_items[0][2], $item[2], $sub_item_url, and $sub_item[2] contain? If they can have absolute URLs already, then it seems like this would cause some unexpected explosions, wouldn't it?

This ticket was mentioned in Slack in #core by chriscct7. View the logs.


10 years ago

#8 @chriscct7
10 years ago

  • Milestone changed from 4.7 to Future Release

Sharing the same concerns @aaroncampbell had with what could be in those indexes. Also @jorbin made a great point about future compatibility concerns. Punting for now

Note: See TracTickets for help on using tickets.