Remove boldness from update notices

[ocean90]

Previously: ​https://wordpress.slack.com/archives/design/p1466093104000007

The notices are currently inconsistent, some are bold, some are not, and some use bold only to highlight words.

OH: Bold text is just wasted bandwidth.

[Presskopp]

First patch

[Presskopp]

Patch. Hope I detected them all.

@ocean90

Two questions

1) OH === Oral Hygiene ?
2) Where did you find this chubby "Permalink structure updated"? Is it

\wp-admin\edit-tag-form.php, L.75

or did I just destroy something?

[ocean90]

Replying to Presskopp:

2) Where did you find this chubby "Permalink structure updated"?

It's passed to add_settings_error() and printed by settings_errors().

[Presskopp]

Ok, if I'm not mistaking, that makes it a patch. But wait! Is there any good in this:

printf(__('Comment by %s moved to the trash.'), '<strong></strong>');
printf(__('Comment by %s marked as spam.'), '<strong></strong>');

found in

\wp-admin\includes\template.php, L.465/468

So what about

printf(__('Comment by %s moved to the trash.'));
printf(__('Comment by %s marked as spam.'));

[Presskopp]

comments please, this is adding some more lines as a separate patch

[dd32]

Replying to Presskopp:

Ok, if I'm not mistaking, that makes it a patch. But wait! Is there any good in this:

printf(__('Comment by %s moved to the trash.'), '<strong></strong>');
printf(__('Comment by %s marked as spam.'), '<strong></strong>');

If you look at how it's actually used in the UI, the JS fills the <strong> tags in with the commenter's name.
Javascript doesn't understand %s as a placeholder, so HTML tags are used instead. If we want to remove the bolding of the username here we'd need to replace it with something such as <span></span> and update whatever JS uses it to search for the span tag rather than strong.

[Presskopp]

thanks @dd32

If we want to keep it simple (not changing tags for JS), all I see left now would be this line:

$output .= "<p><strong>{$details['message']}</strong></p>"; in template.php L.1480

I must not be the one doing the final patch, as always just trying to contribute.

[jpolakovic]

@dd32 I have created a patch that consolidates all the code @Presskopp contributed so far, plus I'm adding a simple fix for removing the boldness from the author fields that are populated by the JavaScript in edit-comments.js.

Using jQuery's .replaceWith instead of .text on L283 of edit-comments.js replaces the <strong></strong> placeholder by a text string containing the author name.

[desrosj]

@jpolakovic are you able to refresh this patch? It no longer applies cleanly to trunk.

Spot checking these instances, it appears that there are still inconsistencies. Though, these should be audited as it's possible some have been fixed elsewhere.

[Presskopp]

kind of refreshed patch

[grzim]

@Presskopp it seems like the patch you added has a merge conflict in the file:
wp-admin/options.php.

Can you please resolve it?

[Presskopp]

Sorry hit the button twice, the both .3 and .4 are the same.

Went through this again and this is what I found. Not sure if I got them all, especially when it comes to .js files.

[Presskopp]

related #54437