registered_meta_key_exists() must return only Boolean, not WP_error as it is used by unregister_meta_key() and get_registered_metadata() which alredy return WP_error

[vishalkakadiya]

registered_meta_key_exists() must return only Boolean, not WP_error as it is used by unregister_meta_key() and get_registered_metadata() which has<br />

<?php
if ( ! registered_meta_key_exists( $object_type, $object_subtype, $meta_key ) ) {
                        return new WP_Error( 'invalid_meta_key', __( 'Invalid meta key. Not registered.' ) );
                }

this type of condition and if the WP_error is return then it will not throw error, but it goes further.

[vishalkakadiya]

Refresh this patch added comment and removed if conditions from unregister_meta_key() as it is already checked in registered_meta_key_exists()

[jeremyfelt]

Thanks for the ticket and patch @vishalkakadiya. I've incorporated the boolean return type in the latest patch on #35658.

[jeremyfelt]

wp_object_type_exists() has been removed via [38095].