WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 22 months ago

#37398 closed enhancement (wontfix)

Decrease the comment number before pagination to 20

Reported by: lukecavanagh Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch
Focuses: performance Cc:

Description

The current default in WP core is 50, I think setting the default to 20 would have a increase on performance on WP live sites.

https://codex.wordpress.org/Template_Tags/paginate_comments_links

Attachments (1)

37398.diff (470 bytes) - added by lukecavanagh 4 years ago.
Basic patch

Download all attachments as: .zip

Change History (4)

@lukecavanagh
4 years ago

Basic patch

#2 @lukecavanagh
4 years ago

  • Keywords has-patch added

#3 @earnjam
22 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Right now, pagination is not on by default. Changing this number wouldn't really have any effect on new installations because they would have to enable it first.

There might be a minor performance bump on loading posts that have more than 20 comments who have also enabled pagination, but most of the discussion has actually focused on going the other direction with the per-page number while enabling pagination by default. See #34389.

As a quick test, I did some load testing of a basic post with 20 comments vs with 50 comments. There was no real observable difference between the two.

I'm going to close this as wontfix as I don't think it's would provide enough of a performance boost to justify a change.

Note: See TracTickets for help on using tickets.