WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 5 weeks ago

#37484 new enhancement

Make form in request_filesystem_credentials() in line with WP admin form styling / HTML structure / security

Reported by: dashaluna Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: needs-patch has-screenshots
Focuses: ui, administration Cc:

Description (last modified by SergeyBiryukov)

Currently, the Connection Information form output by request_filesystem_credentials() looks very sad and doesn't reflect the admin form HTML structure and style.

This is how it looks: Screen Shot 2016-07-27 at 13.41.52.png

It would be great if it can be standardised to look like WP admin settings UI, i.e. Screen Shot 2016-07-27 at 13.41.23.png

While at it, it would be great to secure the form code with escape family functions (esc_attr, esc_html and so on).

Attachments (2)

Screen Shot 2016-07-27 at 13.41.23.png (217.9 KB) - added by dashaluna 4 years ago.
Connection Information admin form
Screen Shot 2016-07-27 at 13.41.52.png (380.7 KB) - added by dashaluna 4 years ago.
General Settings admin form

Download all attachments as: .zip

Change History (10)

@dashaluna
4 years ago

Connection Information admin form

@dashaluna
4 years ago

General Settings admin form

#1 @swissspidy
4 years ago

  • Component changed from Formatting to Upgrade/Install

Related / possible duplicate of: #36973

#2 @dashaluna
4 years ago

Oops, sorry I got confused how to add images in the description and now I can't edit it :( Added images as attachments.

#3 @SergeyBiryukov
4 years ago

  • Description modified (diff)

#4 @joedolson
4 years ago

On the accessibility front, these fields should probably be changed to stop using implicit labels, but I don't see any other a11y issues from reviewing the code.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


17 months ago

#8 @afercia
17 months ago

  • Focuses accessibility removed
  • Keywords ui-feedback added
  • Milestone set to Future Release

Reviewed during today's accessibility bug-scrub. Agreed this form would need some love. Not sure there are important accessibility concerns here. Removing the a11y focus and setting to Future Release.

This ticket was mentioned in Slack in #design by estelaris. View the logs.


5 weeks ago

#10 @ibdz
5 weeks ago

  • Keywords needs-patch has-screenshots added; ui-feedback removed

In design triage today, we agreed that this form should keep consistency with other admin forms (Column patterns).

Note: See TracTickets for help on using tickets.