Make form in request_filesystem_credentials() in line with WP admin form styling / HTML structure / security

[dashaluna]

Currently, the Connection Information form output by request_filesystem_credentials() looks very sad and doesn't reflect the admin form HTML structure and style.

This is how it looks: Screen Shot 2016-07-27 at 13.41.52.png​

It would be great if it can be standardised to look like WP admin settings UI, i.e. Screen Shot 2016-07-27 at 13.41.23.png​

While at it, it would be great to secure the form code with escape family functions (esc_attr, esc_html and so on).

[dashaluna]

Connection Information admin form

[dashaluna]

General Settings admin form

[swissspidy]

Related / possible duplicate of: #36973

[dashaluna]

Oops, sorry I got confused how to add images in the description and now I can't edit it :( Added images as attachments.

[joedolson]

On the accessibility front, these fields should probably be changed to stop using implicit labels, but I don't see any other a11y issues from reviewing the code.

[afercia]

Reviewed during today's accessibility bug-scrub. Agreed this form would need some love. Not sure there are important accessibility concerns here. Removing the a11y focus and setting to Future Release.

[ibdz]

In ​design triage today, we agreed that this form should keep consistency with other admin forms (Column patterns).