Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#37509 closed defect (bug) (fixed)

Make plugin number of active installs consistent with plugin directory

Reported by: ovann86 Owned by: dd32
Priority: normal Milestone: 4.7
Component: Plugins Version: 4.2
Severity: normal Keywords: has-screenshots good-first-bug has-patch
Cc: Focuses: ui, administration

Description (last modified by ocean90)

The WordPress Plugin Directory website and the WordPress Add Plugin search results are inconsistent with how they display the number of active installs when the count is low (e.g. less than 10).

In the WordPress Plugin Directory it displays 'Active Installs: Less than 10' and in WordPress it displays '0+ Active Installs'.

Search term to reproduce the search results is 'abn lookup'.

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php?marks=564-569&rev=38119#L561 needs an extra branch for 0 = 'Less than 10', assuming that is the logic that the Plugin Directory uses.

Attachments (4)

WP Plugin Directory Active Installs Count.png​ (2.1 KB ) - added by ovann86 10 years ago.
Active Installs Count as seen in the WordPress Plugin Directory (Less than 10)
WP Add Plugins Active Installs Count.png​ (24.5 KB ) - added by ovann86 10 years ago.
Active Installs Count as seen in WordPress Add Plugins search results (0+ Active Installs)
37509.diff​ (1.3 KB ) - added by ovann86 10 years ago.
Add branches for 'Less Than 10' Active Installs - note using Title Case, as this is the standard used in this section - unlike in the WP Plugin Directory.
37509.2.diff​ (1.3 KB ) - added by ovann86 10 years ago.
Updated previous patch to use yoda conditions for new branches

Download all attachments as: .zip

Change History (12)

@ovann86
10 years ago

Active Installs Count as seen in the WordPress Plugin Directory (Less than 10)

@ovann86
10 years ago

Active Installs Count as seen in WordPress Add Plugins search results (0+ Active Installs)

#1 @ovann86
10 years ago

  • Component General → Plugins
  • Focuses ui administration added
  • Keywords has-screenshots added

#2 @ocean90
10 years ago

  • Description modified (diff)
  • Keywords needs-patch good-first-bug added
  • Milestone Awaiting Review → Future Release
  • Version trunk → 4.2

@ovann86
10 years ago

Add branches for 'Less Than 10' Active Installs - note using Title Case, as this is the standard used in this section - unlike in the WP Plugin Directory.

This ticket was mentioned in ​Slack in #core by ovann86. ​View the logs.


10 years ago

@ovann86
10 years ago

Updated previous patch to use yoda conditions for new branches

#4 @ovann86
10 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#5 @mitchelsliwa
10 years ago

  • Keywords needs-testing removed

The patch applied and it successfully fixed the problem.

#6 @dd32
10 years ago

  • Milestone Future Release → 4.7

#7 @dd32
10 years ago

  • Owner set to dd32
  • Resolution → fixed
  • Status new → closed

In 38729:

Plugins: Display 'Less Than 10' active installs of a plugin rather than '0+' active installs.

Props ovann86.
Fixes #37509.

#8 @dd32
10 years ago

I also switched out the !empty() to isset() to actually show Less than 10 on the plugin detail overview - previously this wasn't shown there when it was in that range.

Note: See TracTickets for help on using tickets.