Deprecate `wp_get_network()`

[flixos90]

Now with get_network() in, the old function wp_get_network() should be deprecated as discussed earlier.

[PieWP]

Added deprecation notice

[PieWP]

Thanks for your observation flixos90, patch file added

[flixos90]

Thanks for the patch @PieWP! We would also need to add the deprecation to the PHPDoc of the function.

And then we get to the tricky part: ms-deprecated.php is loaded after Multisite bootstrap processes, however this function is currently available at that point. What do we do here? Just leave it there and still deprecate it? Adjust the order of files loaded? Or introduce a new file for this kind of deprecated multisite functions (like ms-load-deprecated.php)?

[jeremyfelt]

Replying to flixos90:

And then we get to the tricky part: ms-deprecated.php is loaded after Multisite bootstrap processes, however this function is currently available at that point. What do we do here? Just leave it there and still deprecate it?

We're good to leave it in ms-load.php, we can move it to the bottom of the file.

This is kind of fun because the introduction of wp_get_network() itself in #27003 led to the deprecation of get_current_site_name(). I guess this is progress... :)

See https://core.trac.wordpress.org/ticket/27003#comment:44 for a good summary.

[flixos90]

In 37553.diff​, wp_get_network() is now deprecated and moved to the bottom of ms-load.php.

[jorbin]

Should there be a comment about why the function is located here rather than with the other deprecated functions?

[jeremyfelt]

Replying to jorbin:

Should there be a comment about why the function is located here rather than with the other deprecated functions?

I don't think we need to do that on each function. It may be worth adding a comment above the first deprecated function in this file, get_current_site_name(), to indicate that any deprecated functions from ms-load.php should go here, but that would probably be another ticket.

[jeremyfelt]

In 38515:

Multisite: Deprecate wp_get_network().

wp_get_network() was converted into a wrapper for get_network() in 4.6.0 and can now be deprecated.

This moves wp_get_network() to the bottom of ms-load.php as ms-deprecated.php is not available early enough.

Props PieWP, flixos90.
Fixes #37553.

[desrosj]

Linking the dev note that was published here for reference: ​https://make.wordpress.org/core/2016/11/04/multisite-focused-changes-in-4-7/