WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#37576 closed enhancement (fixed)

Make 'white' in CSS-files #fff

Reported by: Presskopp Owned by: jorbin
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.6
Component: Administration Keywords: has-patch commit
Focuses: ui Cc:
PR Number:

Description

There are some instances of color: white I did change to #fff

Attachments (4)

37576.diff (6.1 KB) - added by Presskopp 3 years ago.
37576.patch (684 bytes) - added by johnpgreen 3 years ago.
37576.2.diff (609 bytes) - added by Presskopp 3 years ago.
37576.2.patch (1.3 KB) - added by johnpgreen 3 years ago.

Download all attachments as: .zip

Change History (12)

@Presskopp
3 years ago

#1 @ocean90
3 years ago

It looks like you have patched files which are automatically generated during our build process. Can you please use https://develop.svn.wordpress.org/ for patches?

#2 @Presskopp
3 years ago

Uh, aha, I'm sorry, I don't know exactly, is it about patching:

https://develop.svn.wordpress.org/trunk/src/wp-admin/css/colors/_mixins.scss, L.5

@mixin button( $button-color, $text-color: white ) {

?

Somebody else take over please.

#3 @SergeyBiryukov
3 years ago

  • Component changed from General to Administration
  • Focuses ui added

@johnpgreen
3 years ago

#4 @johnpgreen
3 years ago

  • Keywords has-patch added

Updated patch to only touch non-generated files.

@Presskopp
3 years ago

#5 @Presskopp
3 years ago

If this is it...

@johnpgreen
3 years ago

#6 @johnpgreen
3 years ago

Updated patch to include both non-generated files and mixins file.

#7 @netweb
3 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.7

Patch 37576.2.patch looks good, thanks @Presskopp and @johnpgreen

#8 @jorbin
3 years ago

  • Owner set to jorbin
  • Resolution set to fixed
  • Status changed from new to closed

In 38501:

Administration: Use #fff instead of white

Cleans up a few places where the CSS coding standards were not being followed.

Fixes #37576.
Props Presskopp, johnpgreen, netweb

Note: See TracTickets for help on using tickets.