WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#37636 closed defect (bug) (invalid)

wp_get_attachment_image_srcset not well implemented in header of twenty sixteen

Reported by: michelwppi Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.6
Component: Bundled Theme Keywords:
Focuses: Cc:
PR Number:

Description

attribut srcset in header is not well implemented ! get_custom_header don't have property attachment_id !
Line number 93 of header.php - version 1.2

srcset="<?php echo esc_attr( wp_get_attachment_image_srcset( get_custom_header()->attachment_id ) ); ?>"

Change History (2)

#1 @michelwppi
3 years ago

to complete : attachment_id property is available if image is coming from media library. But some time images came from theme sub folder. A test must be done with this property.

#2 @ocean90
3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Hello @michelwppi, thanks for your report.

Twenty Sixteen is developed on GitHub. Can you please create an issue at https://github.com/WordPress/twentysixteen/issues? Thank you!

Note: See TracTickets for help on using tickets.