Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#37657 closed defect (bug) (fixed)

AJAX search on Plugins screen should remove highlighting from status filters

Reported by: johnbillion's profile johnbillion Owned by: swissspidy's profile swissspidy
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.6
Component: Plugins Keywords: ux-feedback has-patch has-screenshots commit
Focuses: administration Cc:

Description

Steps to reproduce:

  1. Visit the Plugins screen and click one of the status filters, such as Active.
  2. Enter some text in the Search installed plugins... box, but don't hit enter.
  3. Note that the AJAX search results include plugins of any status, yet the Active filter link is still highlighted.
  4. Bonus: Clear the search box, and the screen will display all plugins, not just the active plugins.

Attachments (5)

37657.diff (1.8 KB) - added by swissspidy 10 years ago.
before-ajax.png (143.6 KB) - added by swissspidy 10 years ago.
before-reload.png (142.7 KB) - added by swissspidy 10 years ago.
after-ajax.png (157.7 KB) - added by swissspidy 10 years ago.
after-clear.png (65.0 KB) - added by swissspidy 10 years ago.

Download all attachments as: .zip

Change History (15)

@swissspidy
10 years ago

#1 @swissspidy
10 years ago

  • Keywords has-patch added; needs-patch removed

We should fix this in 4.6.1.

37657.diff is a proof-of-concept patch that addresses these issues.

  • Display the filtered list of plugins again when clearing the search box
  • Removes the current class from the filter navigation when doing a search to match behaviour when you reload the page

I'm not sure the search should be limited to the filter currently being set, e.g. only search inside active plugins. That's not the case for the "Add Plugins" screen either. There, it's more clear because of the added "Search Results" tab.

#2 @johnbillion
10 years ago

  • Milestone changed from Awaiting Review to Future Release

#3 @swissspidy
10 years ago

  • Milestone changed from Future Release to 4.7

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


10 years ago

#5 @johnbillion
10 years ago

  • Keywords needs-testing added

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


10 years ago

#7 @johnbillion
10 years ago

  • Owner set to swissspidy
  • Status changed from new to assigned

#8 @swissspidy
10 years ago

  • Keywords has-screenshots commit added; needs-testing removed

This ticket was mentioned in Slack in #core by helen. View the logs.


10 years ago

#10 @swissspidy
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39099:

Plugins: Improve Ajax search of installed plugins.

Removes the highlight from the current filter when performing an Ajax search and adds it back when clearing the search input.

Fixes #37657.

Note: See TracTickets for help on using tickets.