Opened 8 years ago
Closed 8 years ago
#37657 closed defect (bug) (fixed)
AJAX search on Plugins screen should remove highlighting from status filters
Reported by: | johnbillion | Owned by: | swissspidy |
---|---|---|---|
Milestone: | 4.7 | Priority: | normal |
Severity: | normal | Version: | 4.6 |
Component: | Plugins | Keywords: | ux-feedback has-patch has-screenshots commit |
Focuses: | administration | Cc: |
Description
Steps to reproduce:
- Visit the Plugins screen and click one of the status filters, such as
Active
. - Enter some text in the
Search installed plugins...
box, but don't hit enter. - Note that the AJAX search results include plugins of any status, yet the
Active
filter link is still highlighted. - Bonus: Clear the search box, and the screen will display all plugins, not just the active plugins.
Attachments (5)
Change History (15)
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
8 years ago
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
8 years ago
This ticket was mentioned in Slack in #core by helen. View the logs.
8 years ago
Note: See
TracTickets for help on using
tickets.
We should fix this in 4.6.1.
37657.diff is a proof-of-concept patch that addresses these issues.
current
class from the filter navigation when doing a search to match behaviour when you reload the pageI'm not sure the search should be limited to the filter currently being set, e.g. only search inside active plugins. That's not the case for the "Add Plugins" screen either. There, it's more clear because of the added "Search Results" tab.