WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#37732 closed enhancement (fixed)

Add a space after a period in docs

Reported by: ixkaito's profile ixkaito Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.7 Priority: normal
Severity: normal Version: 2.7
Component: Posts, Post Types Keywords: has-patch
Focuses: docs Cc:

Description


Attachments (3)

37732.diff​ (671 bytes) - added by ixkaito 8 years ago.
37732.2.diff​ (942 bytes) - added by swissspidy 8 years ago.
37732.3.diff​ (944 bytes) - added by ixkaito 8 years ago.

Download all attachments as: .zip

Change History (7)

@ixkaito
8 years ago

@swissspidy
8 years ago

#1 @swissspidy
8 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.7
  • Version changed from 0.71 to 2.7

Thanks for the patch! Introduced in [9138].

It looks like the docblock can be further improved. For example, the default value should be at the end of the parameter description, not at the beginning. Also, the default value for the other params isn't documented.

Adjusted the docs in 37732.2.diff​ according to our ​PHP documentation standards.

@ixkaito
8 years ago

#2 @ixkaito
8 years ago

Thanks @swissspidy ! It seems periods are missed of $before and after.

#3 @swissspidy
8 years ago

Oh yeah, you're right. Thanks!

#4 @SergeyBiryukov
8 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 38348:

Docs: Improve the docs for the_title() and make them more consistent with the_title_attribute().

Props ixkaito, swissspidy.
Fixes #37732.

Note: See TracTickets for help on using tickets.