Visual Editor: Weird unicode (vietnamese) characters display on Wordpress 4.6

[nmt90]

On Windows 10, the default font for Visual Editor is very bad for Vietnamese unicode characters, please see the attachment for detail.

[azaozz]

Hi @nmt90, thanks for the bug report.

Does this work better if you change the font, and if yes, which commonly available font works best?

If not, does the post look properly on the front-end and if you load it first in the Text editor (switch to Text and reload the page)?

[nmt90]

Replying to azaozz:

Hi @nmt90, thanks for the bug report.

Does this work better if you change the font, and if yes, which commonly available font works best?

If not, does the post look properly on the front-end and if you load it first in the Text editor (switch to Text and reload the page)?

Thank you, @azaozz,

I think the problem is "Georgia" font and the good choice is as same as left menu's font family, or the set: "Segoe UI",Roboto, sans-serif. I tried with "Segoe UI" (default windows 8 - 10 font) and the Vietnamese character display well.

[azaozz]

In 37755.patch: make the default fonts in the editor the same as rest of the admin.

With some quick testing this can also be considered for 4.6.1 although it isn't a regression from 4.5. Fixing the editor in one locale is worth it :)

[nmt90]

Replying to azaozz:

In 37755.patch: make the default fonts in the editor the same as rest of the admin.

With some quick testing this can also be considered for 4.6.1 although it isn't a regression from 4.5. Fixing the editor in one locale is worth it :)

It sound nice, thanks for your help, @azaozz. We (Vietnamese devs) look forward to get this patch version. :D

[iamfriendly]

(following on from Slack discussion) I'm not a designer or front-end guy but I'm concerned that the proposed patch is a big change for a minor release. Going from a sans-serif stack to a serif stack seems like one which could be jarring and unexpected.

Do we have a native system font serif stack? Could that be a viable alternative?

[swissspidy]

Moving to the 4.7 milestone for more discussion as discussed in today's bug scrub

[jeremyfelt]

@melchoyce's comment during the 4.6.1 bug scrub today led me to revisit ​https://make.wordpress.org/core/2016/07/07/native-fonts-in-4-6/, which mentions that the decision to stick with serif is intentional:

The operating system’s UI font is used for any text that’s part of the WordPress user interface. In other contexts, like the Editor, we continue to use a serif system typeface, Georgia. This creates a clear typographic distinction between text that is part of the interface, and text that is part of the user’s content.

[azaozz]

Replying to jeremyfelt:

@melchoyce's comment during the 4.6.1 bug scrub today led me to revisit ​https://make.wordpress.org/core/2016/07/07/native-fonts-in-4-6/, which mentions that the decision to stick with serif is intentional

OK, lets change the font stack just for Vietnamese. We do that already for all RTL languages and separately for he_IL.

In 37755.1.patch: change the default editor fonts for the vi locale to Arial, "Times New Roman", "Bitstream Charter", Times, serif;, same as for he_IL.

@nmt90 as far as I see this stack is good for Vietnamese. If not, could you suggest a better one.

Still thinking this can be patched in 4.6.1 :)

[nmt90]

Replying to azaozz:

Replying to jeremyfelt:

@melchoyce's comment during the 4.6.1 bug scrub today led me to revisit ​https://make.wordpress.org/core/2016/07/07/native-fonts-in-4-6/, which mentions that the decision to stick with serif is intentional

OK, lets change the font stack just for Vietnamese. We do that already for all RTL languages and separately for he_IL.

In 37755.1.patch: change the default editor fonts for the vi locale to Arial, "Times New Roman", "Bitstream Charter", Times, serif;, same as for he_IL.

@nmt90 as far as I see this stack is good for Vietnamese. If not, could you suggest a better one.

Still thinking this can be patched in 4.6.1 :)

@azaozz : The stack 'Arial, "Times New Roman", "Bitstream Charter", Times, serif;' is good for Vietnamese characters. :)

[SergeyBiryukov]

Moving back for 37755.1.patch​ consideration.

[swissspidy]

37755.1.patch​ is a legitimate patch, but is this really a regression in 4.6? See comment no. 4.

Also, if we'd gonna change this in 4.6.1, would any other languages profit from such a fix as well?

[azaozz]

Replying to swissspidy:

No, not a regression in 4.6 but the fix is so trivial and the impact is so large that it will be pity not fixing it now. Also think we should do #37808 which is somewhat similar, although that would mean backporting the fix and pushing an update to TinyMCE.

...would any other languages profit from such a fix as well?

Unfortunately we wouldn't know unless the users or developers that understand these languages speak up.

[azaozz]

In 38427:

TinyMCE: change the default font for the vi locale to the same stack as he_IL.

Props nmt90 for reporting and testing this.
Fixes #37755 for trunk.

[azaozz]

Reopen for 4.6.1 consideration.

[pento]

I agree, this is small enough and high enough impact to include in 4.6.1.

[jeremyfelt]

In 38472:

TinyMCE: change the default font for the vi locale to the same stack as he_IL.

Merge of [38427] to the 4.6 branch.

Props azaozz, nmt90 for reporting and testing.
Fixes #37755.