WordPress.org

Make WordPress Core

#37755 closed defect (bug) (fixed)

Visual Editor: Weird unicode (vietnamese) characters display on Wordpress 4.6

Reported by: nmt90 Owned by: azaozz
Milestone: 4.6.1 Priority: normal
Severity: normal Version: 4.6
Component: Themes Keywords: has-patch commit fixed-major
Focuses: ui Cc:

Description

On Windows 10, the default font for Visual Editor is very bad for Vietnamese unicode characters, please see the attachment for detail.

Attachments (3)

Thêm bài viết ‹ Guitar Tran — WordPress.png (294.2 KB) - added by nmt90 22 months ago.
37755.patch (587 bytes) - added by azaozz 22 months ago.
37755.1.patch (534 bytes) - added by azaozz 22 months ago.

Download all attachments as: .zip

Change History (22)

#1 @nmt90
22 months ago

  • Component changed from TinyMCE to Editor

#2 follow-up: @azaozz
22 months ago

  • Keywords reporter-feedback added

Hi @nmt90, thanks for the bug report.

Does this work better if you change the font, and if yes, which commonly available font works best?

If not, does the post look properly on the front-end and if you load it first in the Text editor (switch to Text and reload the page)?

#3 in reply to: ↑ 2 @nmt90
22 months ago

Replying to azaozz:

Hi @nmt90, thanks for the bug report.

Does this work better if you change the font, and if yes, which commonly available font works best?

If not, does the post look properly on the front-end and if you load it first in the Text editor (switch to Text and reload the page)?

Thank you, @azaozz,

I think the problem is "Georgia" font and the good choice is as same as left menu's font family, or the set: "Segoe UI",Roboto, sans-serif. I tried with "Segoe UI" (default windows 8 - 10 font) and the Vietnamese character display well.

@azaozz
22 months ago

#4 follow-up: @azaozz
22 months ago

  • Component changed from Editor to Themes
  • Focuses ui added
  • Keywords has-patch needs-testing added; reporter-feedback removed
  • Milestone changed from Awaiting Review to 4.6.1

In 37755.patch: make the default fonts in the editor the same as rest of the admin.

With some quick testing this can also be considered for 4.6.1 although it isn't a regression from 4.5. Fixing the editor in one locale is worth it :)

#5 in reply to: ↑ 4 @nmt90
22 months ago

Replying to azaozz:

In 37755.patch: make the default fonts in the editor the same as rest of the admin.

With some quick testing this can also be considered for 4.6.1 although it isn't a regression from 4.5. Fixing the editor in one locale is worth it :)

It sound nice, thanks for your help, @azaozz. We (Vietnamese devs) look forward to get this patch version. :D

This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.


22 months ago

#7 @iamfriendly
22 months ago

(following on from Slack discussion) I'm not a designer or front-end guy but I'm concerned that the proposed patch is a big change for a minor release. Going from a sans-serif stack to a serif stack seems like one which could be jarring and unexpected.

Do we have a native system font serif stack? Could that be a viable alternative?

#8 @swissspidy
22 months ago

  • Milestone changed from 4.6.1 to 4.7

Moving to the 4.7 milestone for more discussion as discussed in today's bug scrub

#9 follow-up: @jeremyfelt
22 months ago

@melchoyce's comment during the 4.6.1 bug scrub today led me to revisit https://make.wordpress.org/core/2016/07/07/native-fonts-in-4-6/, which mentions that the decision to stick with serif is intentional:

The operating system’s UI font is used for any text that’s part of the WordPress user interface. In other contexts, like the Editor, we continue to use a serif system typeface, Georgia. This creates a clear typographic distinction between text that is part of the interface, and text that is part of the user’s content.

@azaozz
22 months ago

#10 in reply to: ↑ 9 ; follow-up: @azaozz
22 months ago

Replying to jeremyfelt:

@melchoyce's comment during the 4.6.1 bug scrub today led me to revisit https://make.wordpress.org/core/2016/07/07/native-fonts-in-4-6/, which mentions that the decision to stick with serif is intentional

OK, lets change the font stack just for Vietnamese. We do that already for all RTL languages and separately for he_IL.

In 37755.1.patch: change the default editor fonts for the vi locale to Arial, "Times New Roman", "Bitstream Charter", Times, serif;, same as for he_IL.

@nmt90 as far as I see this stack is good for Vietnamese. If not, could you suggest a better one.

Still thinking this can be patched in 4.6.1 :)

#11 in reply to: ↑ 10 @nmt90
22 months ago

Replying to azaozz:

Replying to jeremyfelt:

@melchoyce's comment during the 4.6.1 bug scrub today led me to revisit https://make.wordpress.org/core/2016/07/07/native-fonts-in-4-6/, which mentions that the decision to stick with serif is intentional

OK, lets change the font stack just for Vietnamese. We do that already for all RTL languages and separately for he_IL.

In 37755.1.patch: change the default editor fonts for the vi locale to Arial, "Times New Roman", "Bitstream Charter", Times, serif;, same as for he_IL.

@nmt90 as far as I see this stack is good for Vietnamese. If not, could you suggest a better one.

Still thinking this can be patched in 4.6.1 :)

@azaozz : The stack 'Arial, "Times New Roman", "Bitstream Charter", Times, serif;' is good for Vietnamese characters. :)

#12 @SergeyBiryukov
22 months ago

  • Milestone changed from 4.7 to 4.6.1

Moving back for 37755.1.patch consideration.

#13 follow-up: @swissspidy
22 months ago

37755.1.patch is a legitimate patch, but is this really a regression in 4.6? See comment no. 4.

Also, if we'd gonna change this in 4.6.1, would any other languages profit from such a fix as well?

#14 in reply to: ↑ 13 @azaozz
22 months ago

Replying to swissspidy:

No, not a regression in 4.6 but the fix is so trivial and the impact is so large that it will be pity not fixing it now. Also think we should do #37808 which is somewhat similar, although that would mean backporting the fix and pushing an update to TinyMCE.

...would any other languages profit from such a fix as well?

Unfortunately we wouldn't know unless the users or developers that understand these languages speak up.

#15 @azaozz
22 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 38427:

TinyMCE: change the default font for the vi locale to the same stack as he_IL.

Props nmt90 for reporting and testing this.
Fixes #37755 for trunk.

#16 @azaozz
22 months ago

  • Keywords needs-testing removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 4.6.1 consideration.

#17 @pento
22 months ago

  • Keywords commit added

I agree, this is small enough and high enough impact to include in 4.6.1.

#18 @dd32
22 months ago

  • Keywords fixed-major added

#19 @jeremyfelt
22 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 38472:

TinyMCE: change the default font for the vi locale to the same stack as he_IL.

Merge of [38427] to the 4.6 branch.

Props azaozz, nmt90 for reporting and testing.
Fixes #37755.

Note: See TracTickets for help on using tickets.