HTTP API No Longer Accepts Integer and Float Values for the 'cookies' Argument since v4.6

[miunosoft]

It seems integer and float values set to the cookies argument of wp_remote_get() and wp_remote_post() get lost with v4.6.

wp_remote_get(
    $request_url,   
    array(          
        'timeout'       => 0.01, 
        'blocking'      => false,
        'cookies'       => array(
            'x' => 'foo', // Okay
            'y' => 2,     // disappears
            'z' => 0.45', // disappears
        ),
    ) 
);

[swissspidy]

@miunosoft Is 'z' => 0.45' simply a typo when posting here in trac?

[miunosoft]

Replying to swissspidy:

@miunosoft Is 'z' => 0.45' simply a typo when posting here in trac?

@swissspidy Indeed, that was a typo. Sorry.

[swissspidy]

WP_Http::normalize_cookies() only checks for values that are instances of WP_Http_Cookie and strings. Any other scalar value gets ignored. That method was introduced in 4.6 so something definitely changed there.

37768.diff​ changes this by casting scalars to strings.

@dd32 @rmccue As I am not that familiar with the HTTP API, I'd love to hear your opinion on this.

[dd32]

In 38430:

HTTP: Accept non-string values in cookies, fixing a regression since 4.5.

Props swissspidy.
Fixes #37768 for trunk.

[dd32]

In 38461:

HTTP: Accept non-string values in cookies, fixing a regression since 4.5.

Props swissspidy.
Merges [38430] to the 4.6 branch.
Fixes #37768.