WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#37842 closed enhancement (fixed)

Make the tests for `comment_exists()` a little bit faster.

Reported by: anonymized_8769252's profile anonymized_8769252 Owned by: boonebgorges's profile boonebgorges
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.4
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

The current test methods in Tests_Admin_IncludesComment each create their own posts and comments.

It is possible to run the same tests by using a post with two comments attached, which is used by all tests.

Attachments (1)

37842.diff​ (4.3 KB) - added by anonymized_8769252 10 years ago.

Download all attachments as: .zip

Change History (4)

@anonymized_8769252
10 years ago

#1 @boonebgorges
10 years ago

  • Milestone changed from Awaiting Review to 4.7
  • Owner set to boonebgorges
  • Status changed from new to assigned

Dy-no-mite! Thanks for the patch.

#2 @boonebgorges
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38372:

Use shared fixture in comment_exists() tests.

Props Frank Klein.
Fixes #37842.

#3 @DrewAPicture
10 years ago

  • Keywords has-patch added
Note: See TracTickets for help on using tickets.