Don't attach events to customizer section headings with cannot-expand class
|Reported by:||celloexpressions||Owned by:||westonruter|
|Component:||Customize||Keywords:||has-patch commit good-first-bug|
Back when the customizer used accordion.js, the .cannot-expand class could be added to section headings that couldn't be expanded to prevent JS events and hover/focus styles from being applied. While the class continues to prevent styles from being applied (and is used in a couple places for core), JS events seem to be added now and those should be removed. See https://wordpress.slack.com/archives/themereview/p1473274466001022.
The fix should be reasonably straightforward - bailing early from attachEvents() or onChangeExpanded() in the section JS in customize-controls.js if the event target has class cannot-expand - so I'm marking as a good first bug for now if anyone's interested in tackling it.
Change History (17)
6 months ago
5 months ago
- Keywords needs-patch added; has-patch commit removed
- Owner changed from westonruter to celloexpressions
- Keywords has-patch commit added; needs-patch removed
- Owner changed from celloexpressions to westonruter