WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 12 months ago

Last modified 12 months ago

#38080 closed defect (bug) (fixed)

Focusing a customizer control from the preview should show the controls on mobile

Reported by: celloexpressions Owned by: seancjones
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.1
Component: Customize Keywords: has-patch
Focuses: javascript Cc:

Description

When shift-clicking on a partial in the preview, we now open the controls pane if it was collapsed as of #36678. Similarly, on mobile we should show the controls pane when a control is focused from the preview. This is of course not something users will commonly run into currently, since shift-click typically isn't available on small-screen devices; however, it will be necessary for things like #27403 to work.

This should be fixed similarly to #36678, potentially by leveraging the same paneVisible value on mobile when the controls are toggled.

Attachments (2)

38080.diff (681 bytes) - added by seancjones 12 months ago.
Unified Customizer behavior on small/mobile and large views.
38080.1.diff (702 bytes) - added by westonruter 12 months ago.
Add full path in diff and add spacing

Download all attachments as: .zip

Change History (15)

#1 @westonruter
13 months ago

  • Summary changed from Focusing a customizer control from the preview should show the controls on mible to Focusing a customizer control from the preview should show the controls on mobile

Perhaps the an equally cross theme-compatible to shift-click on mobile devices is long press. The problem with that, however, is there is no tooltip that would show as when hovering is done.

#2 @celloexpressions
13 months ago

Yeah, I think if we can fix the bug with not opening the controls pane here, the actual UI can be worked out in #27403.

This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.


13 months ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


12 months ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


12 months ago

#6 @jbpaul17
12 months ago

  • Owner set to seancjones
  • Status changed from new to assigned

#7 @celloexpressions
12 months ago

  • Keywords good-first-bug added

We have visible edit icons now, so we definitely need this in 4.7. Are you working on a patch @seancjones?

#8 @seancjones
12 months ago

Yes, I have time this weekend and I plan to take care of it then if not sooner.

@seancjones
12 months ago

Unified Customizer behavior on small/mobile and large views.

#9 @seancjones
12 months ago

That should do it. There's an added benefit of the state of the Preview Pane being the same between small and large screens, so toggling hide/show panel will be the same in an expanded and contracted window.

#10 @seancjones
12 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

This ticket was mentioned in Slack in #core-customize by seancjones. View the logs.


12 months ago

@westonruter
12 months ago

Add full path in diff and add spacing

#12 @westonruter
12 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39010:

Customize: Reveal controls pane when clicking on edit shortcuts in mobile preview.

Re-use paneVisible state to also manage whether the mobile preview-only class is applied to the overlay.

Props seancjones.
See #36678, #36678, #27403.
Fixes #38080.

#13 @westonruter
12 months ago

  • Keywords good-first-bug needs-testing removed

@seancjones excellent work. It's actually fun to use the customizer on mobile now!

Note: See TracTickets for help on using tickets.