#38080 closed defect (bug) (fixed)
Focusing a customizer control from the preview should show the controls on mobile
Reported by: | celloexpressions | Owned by: | seancjones |
---|---|---|---|
Milestone: | 4.7 | Priority: | normal |
Severity: | normal | Version: | 4.1 |
Component: | Customize | Keywords: | has-patch |
Focuses: | javascript | Cc: |
Description
When shift-clicking on a partial in the preview, we now open the controls pane if it was collapsed as of #36678. Similarly, on mobile we should show the controls pane when a control is focused from the preview. This is of course not something users will commonly run into currently, since shift-click typically isn't available on small-screen devices; however, it will be necessary for things like #27403 to work.
This should be fixed similarly to #36678, potentially by leveraging the same paneVisible
value on mobile when the controls are toggled.
Attachments (2)
Change History (15)
#1
@
8 years ago
- Summary changed from Focusing a customizer control from the preview should show the controls on mible to Focusing a customizer control from the preview should show the controls on mobile
#2
@
8 years ago
Yeah, I think if we can fix the bug with not opening the controls pane here, the actual UI can be worked out in #27403.
This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.
8 years ago
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
8 years ago
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
8 years ago
#7
@
8 years ago
- Keywords good-first-bug added
We have visible edit icons now, so we definitely need this in 4.7. Are you working on a patch @seancjones?
#9
@
8 years ago
That should do it. There's an added benefit of the state of the Preview Pane being the same between small and large screens, so toggling hide/show panel will be the same in an expanded and contracted window.
Perhaps the an equally cross theme-compatible to shift-click on mobile devices is long press. The problem with that, however, is there is no tooltip that would show as when hovering is done.