"cURL error 23: Failed writing body" when updating plugins or themes

[SergeyBiryukov]

After upgrading to 4.6, ​some users reported an error when upgrading plugins or themes:

Download failed. cURL error 23: Failed writing body (624 != 811)

Apparently it happens if mbstring.func_overload is enabled and body length is calculated incorrectly.

Previously, this was solved by using mbstring_binary_safe_encoding()/reset_mbstring_encoding(), see [25348].

However, [37428] removed those calls, and it seems like Requests is not mbstring-aware.

[SergeyBiryukov]

38226.patch​ restores mbstring_binary_safe_encoding()/reset_mbstring_encoding() calls.

Needs testing on the affected installs.

[dd32]

opened ​https://github.com/rmccue/Requests/issues/244 upstream

[SergeyBiryukov]

Got ​at least one report that the patch does resolve the issue.

Found another thread on the English forums, commented there:
​https://wordpress.org/support/topic/after-update-to-46-keep-getting-curl-error-23/page/2/#post-8157376

[fierevere]

3 more patch success reports
1) ​https://ru.wordpress.org/support/topic/%d0%be%d1%88%d0%b8%d0%b1%d0%ba%d0%b0-%d0%be%d0%b1%d0%bd%d0%be%d0%b2%d0%bb%d0%b5%d0%bd%d0%b8%d1%8f-%d0%bf%d0%bb%d0%b0%d0%b3%d0%b8%d0%bd%d0%be%d0%b2-%d0%bf%d0%be%d1%81%d0%bb%d0%b5-%d1%83%d1%81%d1%82/page/5/#post-222985

2) ​https://ru.wordpress.org/support/topic/%d0%be%d1%88%d0%b8%d0%b1%d0%ba%d0%b0-%d0%be%d0%b1%d0%bd%d0%be%d0%b2%d0%bb%d0%b5%d0%bd%d0%b8%d1%8f-%d0%bf%d0%bb%d0%b0%d0%b3%d0%b8%d0%bd%d0%be%d0%b2-%d0%bf%d0%be%d1%81%d0%bb%d0%b5-%d1%83%d1%81%d1%82/page/5/#post-223861

3) ​https://ru.wordpress.org/support/topic/%d0%be%d1%88%d0%b8%d0%b1%d0%ba%d0%b0-%d0%be%d0%b1%d0%bd%d0%be%d0%b2%d0%bb%d0%b5%d0%bd%d0%b8%d1%8f-%d0%bf%d0%bb%d0%b0%d0%b3%d0%b8%d0%bd%d0%be%d0%b2-%d0%bf%d0%be%d1%81%d0%bb%d0%b5-%d1%83%d1%81%d1%82/page/6/#post-223866

[dd32]

In 38894:

HTTP: Call mbstring_binary_safe_encoding() before making a request with Requests to avoid issues with mbstring.func_overload.

Props SergeyBiryukov.
Fixes #38226.

[dd32]

In 38895:

HTTP: Call mbstring_binary_safe_encoding() before making a request with Requests to avoid issues with mbstring.func_overload.

Props SergeyBiryukov.
Merges [38894] to the 4.6 branch.
Fixes #38226.