WordPress.org

Make WordPress Core

Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#38372 closed enhancement (fixed)

Twenty Seventeen

Reported by: davidakennedy Owned by: pento
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

This is the reference ticket for the Twenty Seventeen theme which is currently under development, ready for 4.7.

https://make.wordpress.org/core/files/2016/10/twenty-seventeen-768x448.png

Initial development happened on GitHub: https://github.com/WordPress/twentyseventeen

Read the announcement post: https://make.wordpress.org/core/2016/09/09/say-hello-to-twenty-seventeen-%F0%9F%91%8B%F0%9F%8F%BD/

And the merge proposal: https://make.wordpress.org/core/2016/10/18/twenty-seventeen-merge-proposal-for-4-7/

Attachments (2)

38372.1.patch (2.0 KB) - added by davidakennedy 15 months ago.
Make Twenty Seventeen the default theme
38372.2.patch (3.0 KB) - added by davidakennedy 15 months ago.
Make Twenty Seventeen the default theme, v2

Download all attachments as: .zip

Change History (16)

This ticket was mentioned in Slack in #core by helen. View the logs.


15 months ago

@davidakennedy
15 months ago

Make Twenty Seventeen the default theme

@davidakennedy
15 months ago

Make Twenty Seventeen the default theme, v2

#2 @davidakennedy
15 months ago

In 38833:

Importing Twenty Seventeen, our new default theme for 2017, set for 4.7.

With a focus on business sites, it will let you get down to business in style. Initial development occurred on GitHub. See: https://github.com/WordPress/twentyseventeen

Props melchoyce, laurelfulford, davidakennedy, grapplerulrich, manishsongirkar36, joefusco, smyoon315, b-07, rabmalin, mrahmadawais, hardeepasrani, implenton, acmethemes, claudiosanches, valeriutihai, pressionate, sgr33n, doughamlin, zodiac1978, tsl143, nikschavan, joshcummingsdesign, enodekciw, jordesign, patilvikasj, ryelle, mahesh901122, williampatton, juanfra, imnok, littlebigthing, mor10, samikeijonen, celloexpressions, akshayvinchurkar, davidmosterd, hiddenpearls, netweb, pratikchaskar, taggon, nukaga, ranh, yoavf, karmatosed, sandesh055, adammacias, noplanman, yogasukma, binarymoon, swapnilld, swissspidy, joyously, allancole, rianrietveld, sixhours, alex27, themeshaper, mapk, leobaiano.

See #38372.

#3 @pento
15 months ago

  • Milestone changed from Awaiting Review to 4.7
  • Owner set to pento
  • Status changed from new to assigned

#4 @pento
15 months ago

In 38837:

Twenty Seventeen: Fix a PHP warning on fresh installs.

When setting the transport parameter on Customizer settings, we need to ensure the setting exists, particularly on new sites.

See #38372.

#5 @pento
15 months ago

In 38838:

Tests: Fix tests that don't pass when Twenty Seventeen is the default theme.

There are some tests who's outcome can be affected by the default theme, so we need to ensure the Twenty Seventeen functionality is unhooked while the tests are running.

See #38372.

#6 @pento
15 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38839:

Themes: Twenty Seventeen is now the default theme.

It's party time!

Fixes #38372.

#7 @pento
15 months ago

In 38841:

Twenty Seventeen: Remove some whitespace accidentally introduced in [38837].

See #38372.

#8 @pento
15 months ago

In 38842:

Tests: Fix ajax tests that fail when Twenty Seventeen is the default theme.

There are some tests who's outcome can be affected by the default theme, so we need to ensure the Twenty Seventeen functionality is unhooked while the tests are running.

See #38372.

#9 @celloexpressions
15 months ago

[38837] should not be necessary, and the previous approach is something that a lot of themes do. Why aren't the customizer settings defined? Their values may be empty, but the setting objects should definitely be there and if they aren't, we should fix that. Themes should not need to do what [38837] does.

#10 @pento
15 months ago

In 38850:

Tests: Prevent Twenty Seventeen from interfering with Customizer tests.

This was previously fixed in [38837], but it wasn't really the correct answer, to fix it in the theme. So, [38837] is reverted in this commit, and the Twenty Seventeen actions causing problems are unhooked before tests are run.

See #38372.

#11 @pento
15 months ago

In 38851:

Tests: Prevent Twenty Seventeen from interfering with Customizer ajax tests.

Missed in [38850].

See #38372.

#12 @ocean90
15 months ago

In 38919:

Install: Update sidebars_widgets option for Twenty Seventeen to match its three sidebars.

See #38372.

#13 @ocean90
15 months ago

In 38920:

Nav Menus: Update help text to include the two latest default themes, Twenty Sixteen and Twenty Seventeen.

See #38372.

#14 @ocean90
15 months ago

In 38921:

Upgrade: Add Twenty Seventeen to $_new_bundled_files.

This indicates that Twenty Seventeen should be installed with a WordPress upgrade.

See #38372.

Note: See TracTickets for help on using tickets.