WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 2 months ago

#38431 new defect (bug)

-webkit-appearance rule should be removed from the CSS

Reported by: laurent22777 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.3
Component: General Keywords: 2nd-opinion close
Focuses: css Cc:

Description

The -webkit-appearance rule used in customize-control.css is not supported properly on all browsers and in some cases might make certain layouts impossible. Please see the MDN article about it:

https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-appearance

As mentioned there, even the "none" value will have different behavior on different browsers. In my case, it forces the element to wrap to the next line on Chrome, and the only way to go around this is to delete the rule directly in the WordPress CSS.

Change History (6)

#1 @desrosj
2 years ago

  • Keywords reporter-feedback added
  • Version changed from 4.6.1 to 4.3

Hi @laurent22777!

Welcome to Trac! My apologies that it took so long to receive a response.

Are you still experiencing this issue? Can you provide some screenshots and code to help others reproduce the issue?

Ticket this was introduced in: #31336

#2 @desrosj
2 years ago

  • Component changed from General to Customize
  • Focuses ui removed

#3 @laurent22777
2 years ago

Well unless you lend me your time machine I can't provide screenshots of something I was working on three years ago :-)

All I know is that for sure the rule "-webkit-appearance" should be removed from the CSS because it doesn't work well, and once it's set it cannot be overridden by the user. As the post said, my fix was to remove it directly from the WordPress CSS.

#4 @celloexpressions
2 months ago

  • Focuses css added
  • Keywords needs-patch 2nd-opinion added; reporter-feedback removed

Does anyone regularly working with core CSS have input on the use of webkit-appearance? Can/should it be removed from any uses in core?

#5 @desrosj
2 months ago

  • Keywords close added; needs-patch removed

Given the data shown on Can I Use, I'm inclined to say these should not be removed. On this page, it's noted that all versions of Safari on desktop and on iOS require the -webkit- prefix for the appearance property to allow for partial support.

Edge, Chrome (-webkit- prefix), and Firefox (-moz- prefix) are no longer required for the appearance property in the versions supported by today's versions of WordPress.

The linked developer documentation above now includes the following clarification:

The differences are smaller in the newest browsers.

Browsers seem to have made the behavior of this property more consistent. So I'm not sure this is really an issue worth addressing anymore. I'm suggesting this one is a close, but would still like someone with more experience using the property to weigh in.

#6 @desrosj
2 months ago

  • Component changed from Customize to General

I'm also going to move this to the General component. The property is used throughout Core, and a coordinated effort would be needed if it should be removed from Core's CSS.

Note: See TracTickets for help on using tickets.