Context Navigation

← Previous Ticket
Next Ticket →

#38602 closed defect (bug) (fixed)

WP_UnitTest_Factory_For_Network::get_object_by_id() calling deprecated wp_get_network()

Reported by:	johnjamesjacoby	Owned by:	jeremyfelt
Priority:	normal	Milestone:	4.7
Component:	Networks and Sites	Version:	4.6
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:	multisite

Description

The WP_UnitTest_Factory_For_Network class's get_object_by_id() method is calling a function that was deprecated in WordPress 4.6: wp_get_network().

It can now safely be replaced with a call to get_network() instead.

(Discovered from failing tests in the WP Multi Network plugin.)

Attachments (1)

38602.patch (569 bytes ) - added by johnjamesjacoby 10 years ago.

Download all attachments as: .zip

Change History (4)

@johnjamesjacoby
10 years ago

Attachment 38602.patch added

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.

10 years ago

#2 @jeremyfelt
10 years ago

Milestone Awaiting Review → 4.7
Owner set to jeremyfelt
Status new → reviewing

Good catch, thanks @johnjamesjacoby.

#3 @jeremyfelt
10 years ago

Resolution → fixed
Status reviewing → closed

In 39071:

Multisite: Use get_network() in WP_UnitTest_Factory_For_Network.

wp_get_network() was deprecated in 4.6.

Props johnjamesjacoby.
Fixes #38602.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core