WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#38625 closed enhancement (fixed)

Explicitly specify the end of the variable name in get_page_template().

Reported by: kuck1u's profile kuck1u Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.8 Priority: low
Severity: normal Version:
Component: Themes Keywords: has-patch
Focuses: template Cc:

Description

  • Explicitly specify the end of the variable name.

Attachments (1)

38625.diff​ (575 bytes) - added by kuck1u 8 years ago.

Download all attachments as: .zip

Change History (6)

@kuck1u
8 years ago

#1 @kuck1u
8 years ago

  • Keywords has-patch added

#2 @kuck1u
8 years ago

  • Component changed from General to Themes
  • Focuses template added

#3 @johnbillion
8 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to low
  • Version trunk deleted

Thanks @kuck1u.

This sort of change would normally fall under code refactoring, which ​the WordPress project typically avoids doing, but this does clarify the variable names and I think we can drop it in as an enhancement.

#4 @SergeyBiryukov
8 years ago

  • Milestone changed from Future Release to 4.8

#5 @SergeyBiryukov
8 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 39884:

Themes: Use curly braces for variables inside strings in `get_page_template() to explicitly specify the end of the variable name.

Props kuck1u.
Fixes #38625.

Note: See TracTickets for help on using tickets.