Add $domain parameter to translate_user_role()

[johnjamesjacoby]

The translate_user_role() function currently only works with WordPress's built-in user roles.

For a plugin like bbPress, it cannot pass the bbpress text domain through to translate_with_gettext_context(), meaning it's roles can only be translated as part of the default text domain.

This becomes more of an issue in WordPress 4.7 due to load-order changes between roles & locales.

Patch imminent.

[johnjamesjacoby]

Add $domain parameter

[jdgrimes]

Say I have a plugin that uses translate_user_role() for each of the roles in WordPress, how do I know which textdomain to pass for each role? (I know this is maybe a separate issue from this ticket, but I hadn't considered it before.)

[johnjamesjacoby]

Replying to jdgrimes:

Say I have a plugin that uses translate_user_role() for each of the roles in WordPress, how do I know which textdomain to pass for each role? (I know this is maybe a separate issue from this ticket, but I hadn't considered it before.)

Good question. Right now, I don't have an answer, since there are no role-groups or domain key.

If a plugin included its own version of this function (as bbPress now does) the problem you describe will still exist for anything trying to loop through all of the roles at once.

[ocean90]

In 44830:

I18N: Add $domain argument to translate_user_role().

The text domain is optional and gets passed to translate_with_gettext_context().

Props johnjamesjacoby .
Fixes #38736.